Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Side by Side Diff: Source/core/editing/VisiblePosition.h

Issue 1313963003: Move honorEditingBoundaryAtOr{Before,After}() out from VisiblePosition class (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-08-31T14:15:42 Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/editing/VisiblePosition.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2004, 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 87
88 bool isNull() const { return m_deepPosition.isNull(); } 88 bool isNull() const { return m_deepPosition.isNull(); }
89 bool isNotNull() const { return m_deepPosition.isNotNull(); } 89 bool isNotNull() const { return m_deepPosition.isNotNull(); }
90 bool isOrphan() const { return m_deepPosition.isOrphan(); } 90 bool isOrphan() const { return m_deepPosition.isOrphan(); }
91 91
92 Position deepEquivalent() const { return m_deepPosition; } 92 Position deepEquivalent() const { return m_deepPosition; }
93 Position toParentAnchoredPosition() const { return deepEquivalent().parentAn choredEquivalent(); } 93 Position toParentAnchoredPosition() const { return deepEquivalent().parentAn choredEquivalent(); }
94 PositionWithAffinity toPositionWithAffinity() const { return PositionWithAff inity(m_deepPosition, m_affinity); } 94 PositionWithAffinity toPositionWithAffinity() const { return PositionWithAff inity(m_deepPosition, m_affinity); }
95 TextAffinity affinity() const { return m_affinity; } 95 TextAffinity affinity() const { return m_affinity; }
96 96
97 // next() and previous() will increment/decrement by a character cluster.
98 VisiblePosition honorEditingBoundaryAtOrBefore(const VisiblePosition&) const ;
99 VisiblePosition honorEditingBoundaryAtOrAfter(const VisiblePosition&) const;
100
101 // TODO(yosin) This does not handle [table, 0] correctly. 97 // TODO(yosin) This does not handle [table, 0] correctly.
102 Element* rootEditableElement() const { return m_deepPosition.isNotNull() ? m _deepPosition.anchorNode()->rootEditableElement() : 0; } 98 Element* rootEditableElement() const { return m_deepPosition.isNotNull() ? m _deepPosition.anchorNode()->rootEditableElement() : 0; }
103 99
104 DECLARE_TRACE(); 100 DECLARE_TRACE();
105 101
106 #ifndef NDEBUG 102 #ifndef NDEBUG
107 void debugPosition(const char* msg = "") const; 103 void debugPosition(const char* msg = "") const;
108 void formatForDebugger(char* buffer, unsigned length) const; 104 void formatForDebugger(char* buffer, unsigned length) const;
109 void showTreeForThis() const; 105 void showTreeForThis() const;
110 #endif 106 #endif
(...skipping 23 matching lines...) Expand all
134 // "VisibleUnits.cpp". 130 // "VisibleUnits.cpp".
135 VisiblePosition leftPositionOf(const VisiblePosition&); 131 VisiblePosition leftPositionOf(const VisiblePosition&);
136 VisiblePosition rightPositionOf(const VisiblePosition&); 132 VisiblePosition rightPositionOf(const VisiblePosition&);
137 133
138 CORE_EXPORT Position canonicalPositionOf(const Position&); 134 CORE_EXPORT Position canonicalPositionOf(const Position&);
139 CORE_EXPORT PositionInComposedTree canonicalPositionOf(const PositionInComposedT ree&); 135 CORE_EXPORT PositionInComposedTree canonicalPositionOf(const PositionInComposedT ree&);
140 // TODO(yosin) We should move |characterAfter()| and |characterBefore()| to 136 // TODO(yosin) We should move |characterAfter()| and |characterBefore()| to
141 // "VisibleUnits.cpp" 137 // "VisibleUnits.cpp"
142 UChar32 characterAfter(const VisiblePosition&); 138 UChar32 characterAfter(const VisiblePosition&);
143 UChar32 characterBefore(const VisiblePosition&); 139 UChar32 characterBefore(const VisiblePosition&);
140
141 // TODO(yosin) We should move |honorEditingBoundaryAtOr{Before,After} to
142 // "VisibleUnits.cpp" as static function.
143 // next() and previous() will increment/decrement by a character cluster.
144 VisiblePosition honorEditingBoundaryAtOrBefore(const VisiblePosition&, const Pos ition& anchor);
144 PositionWithAffinity honorEditingBoundaryAtOrBeforeOf(const PositionWithAffinity &, const Position& anchor); 145 PositionWithAffinity honorEditingBoundaryAtOrBeforeOf(const PositionWithAffinity &, const Position& anchor);
145 PositionInComposedTreeWithAffinity honorEditingBoundaryAtOrBeforeOf(const Positi onInComposedTreeWithAffinity&, const PositionInComposedTree& anchor); 146 PositionInComposedTreeWithAffinity honorEditingBoundaryAtOrBeforeOf(const Positi onInComposedTreeWithAffinity&, const PositionInComposedTree& anchor);
147 VisiblePosition honorEditingBoundaryAtOrAfter(const VisiblePosition&, const Posi tion& anchor);
146 148
147 // TODO(yosin) We should move |nextPositionOf()| to "VisibleUnits.cpp". 149 // TODO(yosin) We should move |nextPositionOf()| to "VisibleUnits.cpp".
148 VisiblePosition nextPositionOf(const VisiblePosition&, EditingBoundaryCrossingRu le = CanCrossEditingBoundary); 150 VisiblePosition nextPositionOf(const VisiblePosition&, EditingBoundaryCrossingRu le = CanCrossEditingBoundary);
149 // TODO(yosin) We should move |previousPositionOf()| to "VisibleUnits.cpp" 151 // TODO(yosin) We should move |previousPositionOf()| to "VisibleUnits.cpp"
150 VisiblePosition previousPositionOf(const VisiblePosition&, EditingBoundaryCrossi ngRule = CanCrossEditingBoundary); 152 VisiblePosition previousPositionOf(const VisiblePosition&, EditingBoundaryCrossi ngRule = CanCrossEditingBoundary);
151 153
152 } // namespace blink 154 } // namespace blink
153 155
154 #ifndef NDEBUG 156 #ifndef NDEBUG
155 // Outside the WebCore namespace for ease of invocation from gdb. 157 // Outside the WebCore namespace for ease of invocation from gdb.
156 void showTree(const blink::VisiblePosition*); 158 void showTree(const blink::VisiblePosition*);
157 void showTree(const blink::VisiblePosition&); 159 void showTree(const blink::VisiblePosition&);
158 #endif 160 #endif
159 161
160 #endif // VisiblePosition_h 162 #endif // VisiblePosition_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/editing/VisiblePosition.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698