Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1313963003: Move honorEditingBoundaryAtOr{Before,After}() out from VisiblePosition class (Closed)

Created:
5 years, 3 months ago by yosin_UTC9
Modified:
5 years, 3 months ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move honorEditingBoundaryAtOr{Before,After}() out from VisiblePosition class This patch moves |honorEditingBoundaryAtOr{Before,After}()| out from |VisiblePosition| class to simplify |VisiblePosition| for introducing composed tree version of |VisiblePosition|. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 BUG=513568 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201467

Patch Set 1 : 2015-08-31T14:15:42 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -22 lines) Patch
M Source/core/editing/VisiblePosition.h View 2 chunks +6 lines, -4 lines 0 comments Download
M Source/core/editing/VisiblePosition.cpp View 5 chunks +10 lines, -10 lines 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 8 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
yosin_UTC9
PTAL
5 years, 3 months ago (2015-08-31 05:46:15 UTC) #2
hajimehoshi
lgtm
5 years, 3 months ago (2015-08-31 06:16:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313963003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313963003/1
5 years, 3 months ago (2015-08-31 06:16:59 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 06:40:11 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201467

Powered by Google App Engine
This is Rietveld 408576698