Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 1313953008: Remove GC metadata of code object before serializing. (Closed)

Created:
5 years, 3 months ago by oth
Modified:
5 years, 3 months ago
Reviewers:
ulan_google, ulan, rmcilroy
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove GC metadata of code object before serializing. Follow up on discussion of https://codereview.chromium.org/1310503006/ BUG= LOG=N Committed: https://crrev.com/b370f6d8230bb75722eed57e5f72ec6db1ce4177 Cr-Commit-Position: refs/heads/master@{#30562}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/objects-inl.h View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (5 generated)
oth
rmcilroy@chromium.org, ulan@chromium.org: PTAL Thanks
5 years, 3 months ago (2015-09-03 12:50:05 UTC) #2
rmcilroy
lgtm, thanks!
5 years, 3 months ago (2015-09-03 12:51:50 UTC) #3
ulan_google
lgtm
5 years, 3 months ago (2015-09-03 12:52:34 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313953008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313953008/1
5 years, 3 months ago (2015-09-03 12:55:41 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-03 13:20:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313953008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313953008/1
5 years, 3 months ago (2015-09-03 13:25:36 UTC) #11
oth
thanks all!
5 years, 3 months ago (2015-09-03 13:26:21 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-03 13:48:04 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 13:48:20 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b370f6d8230bb75722eed57e5f72ec6db1ce4177
Cr-Commit-Position: refs/heads/master@{#30562}

Powered by Google App Engine
This is Rietveld 408576698