Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(17)

Issue 1313873002: Now pulling WebRTC telemetry pages from https instead of http. (Closed)

Created:
3 years, 6 months ago by phoglund_chromium
Modified:
3 years, 6 months ago
Reviewers:
sullivan
CC:
chromium-reviews, posciak+watch_chromium.org, phoglund+watch_chromium.org, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, telemetry-reviews_chromium.org, tnakamura+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Now pulling WebRTC telemetry pages from https instead of http. https://codereview.chromium.org/1301653005 changed getUserMedia so it only works for secure origins, which led gUM to be blocked. This patch makes us pull our demo pages from https instead of http. Web page replay seems to respect https, and will play back as https, so this should solve the problem. BUG=520765, 523517 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect Committed: https://crrev.com/f0d3f1086f14baddc8914d3683125c65c4eed82c Cr-Commit-Position: refs/heads/master@{#345350}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -13 lines) Patch
M tools/perf/benchmarks/webrtc.py View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/data/webrtc_cases.json View 3 chunks +10 lines, -10 lines 0 comments Download
A tools/perf/page_sets/data/webrtc_cases_013.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/page_sets/webrtc_cases.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
phoglund_chromium
3 years, 6 months ago (2015-08-25 07:25:13 UTC) #2
sullivan
lgtm
3 years, 6 months ago (2015-08-25 13:32:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313873002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313873002/20001
3 years, 6 months ago (2015-08-25 14:35:05 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 6 months ago (2015-08-25 16:42:23 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/f0d3f1086f14baddc8914d3683125c65c4eed82c Cr-Commit-Position: refs/heads/master@{#345350}
3 years, 6 months ago (2015-08-25 16:43:10 UTC) #7
phoglund_chromium
3 years, 6 months ago (2015-08-26 15:51:34 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1303193004/ by phoglund@chromium.org.

The reason for reverting is: Breaks
http://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20%284%29..

Powered by Google App Engine
This is Rietveld 408576698