Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(827)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1313863003: Devtools Color: Support decimal values which omit 0 (Closed)

Created:
5 years, 3 months ago by samli
Modified:
5 years, 3 months ago
Reviewers:
pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, yurys+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Devtools Color: Support decimal values which omit 0 BUG=526315 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201491

Patch Set 1 #

Patch Set 2 : Update expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -1 line) Patch
M LayoutTests/inspector/elements/styles-4/styles-invalid-color-values.html View 1 2 chunks +5 lines, -0 lines 0 comments Download
M LayoutTests/inspector/elements/styles-4/styles-invalid-color-values-expected.txt View 1 2 chunks +28 lines, -0 lines 0 comments Download
M Source/devtools/front_end/common/Color.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
samli
5 years, 3 months ago (2015-08-28 23:25:14 UTC) #2
pfeldman
lgtm
5 years, 3 months ago (2015-08-28 23:34:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313863003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313863003/1
5 years, 3 months ago (2015-08-28 23:36:27 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/100489)
5 years, 3 months ago (2015-08-29 00:50:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313863003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313863003/20001
5 years, 3 months ago (2015-08-31 17:44:06 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 18:43:54 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201491

Powered by Google App Engine
This is Rietveld 408576698