Source/devtools/front_end/common/Color.js - Issue 1313863003: Devtools Color: Support decimal values which omit 0

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/common/Color.js

Issue 1313863003: Devtools Color: Support decimal values which omit 0 (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Update expectations Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/devtools/front_end/common/Color.js

diff --git a/Source/devtools/front_end/common/Color.js b/Source/devtools/front_end/common/Color.js

index 06e80e41211bedcfddff7d78386a7771a31bfa80..2be3c2589303442c4f6b555f40d7ed3f5edc4338 100644

--- a/Source/devtools/front_end/common/Color.js

+++ b/Source/devtools/front_end/common/Color.js

@@ -127,7 +127,7 @@ WebInspector.Color.parse = function(text)

}

// Advanced - rgba(), hsla()

- var advanced = /^(?:rgba$((?:-?\d+%?,){3}-?\d+(?:\.\d+)?)$|hsla$(-?\d+\.?\d*(?:,-?\d+\.?\d*%){2},-?\d+(?:\.\d+)?)$)$/;

+ var advanced = /^(?:rgba$((?:-?\d+%?,){3}-?(?:\d+|\d*\.\d+))$|hsla$(-?(?:\d+|\d*\.\d+)(?:,-?(?:\d+|\d*\.\d+)*%){2},-?(?:\d+|\d*\.\d+))$)$/;

match = value.match(advanced);

if (match) {

if (match[1]) { // rgba

« no previous file with comments | « LayoutTests/inspector/elements/styles-4/styles-invalid-color-values-expected.txt ('k') | no next file » | no next file with comments »