Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 1313793005: Fixes a bug where touch device scripts were not cleared on exit of device mode in devtools. (Closed)

Created:
5 years, 4 months ago by andrei.borza
Modified:
5 years, 4 months ago
Reviewers:
dgozman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fixes a bug where touch device scripts were not cleared on exit of device mode in devtools. When selecting more than 1 touch device during device mode in devtools, only the touchevent scripts for the last selected device are cleared upon exiting device mode. Events such as 'ontouchstart', coming from previous devices, will persist. BUG=133915 TEST=Reproduction steps are in https://crbug.com/133915#c46 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201176

Patch Set 1 #

Total comments: 1

Patch Set 2 : Simplified logic for adding/removing touch emulation scripts for device mode. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M Source/devtools/front_end/emulation/OverridesSupport.js View 1 1 chunk +7 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
andrei.borza
Hey, I uploaded a fix as discussed in https://crbug.com/433981#c12. I would like to add my ...
5 years, 4 months ago (2015-08-25 16:45:43 UTC) #2
paulirish
hey andrei, thanks very much for posting the patch! dgozman will take a look and ...
5 years, 4 months ago (2015-08-25 17:35:26 UTC) #3
dgozman
AUTHORS file is in another repository (the chromium one), so please send a separate patch ...
5 years, 4 months ago (2015-08-25 18:02:09 UTC) #4
andrei.borza
On 2015/08/25 18:02:09, dgozman wrote: > AUTHORS file is in another repository (the chromium one), ...
5 years, 4 months ago (2015-08-25 20:33:41 UTC) #5
dgozman
lgtm Thank you for fixing this!
5 years, 4 months ago (2015-08-25 23:24:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313793005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313793005/20001
5 years, 4 months ago (2015-08-25 23:35:49 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-26 00:43:55 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201176

Powered by Google App Engine
This is Rietveld 408576698