Add onMemoryDump to GrContext

src/gpu/gl/GrGLRenderTarget.cpp

Index: src/gpu/gl/GrGLRenderTarget.cpp
diff --git a/src/gpu/gl/GrGLRenderTarget.cpp b/src/gpu/gl/GrGLRenderTarget.cpp
index cb9d310010b596fb7a90cf2d58b3064cca9cccbe..14a53ff7e4c50dce88c6bd6411e12117f24c2164 100644
--- a/src/gpu/gl/GrGLRenderTarget.cpp
+++ b/src/gpu/gl/GrGLRenderTarget.cpp
@@ -8,6 +8,7 @@
 #include "GrGLRenderTarget.h"
 
 #include "GrGLGpu.h"
+#include "SkTraceMemoryDump.h"
 
 #define GPUGL static_cast<GrGLGpu*>(this->getGpu())
 #define GL_CALL(X) GR_GL_CALL(GPUGL->glInterface(), X)
@@ -84,3 +85,31 @@ void GrGLRenderTarget::onAbandon() {
     fMSColorRenderbufferID  = 0;
     INHERITED::onAbandon();
 }
+
+void GrGLRenderTarget::dumpMemoryStatistics(SkTraceMemoryDump* traceMemoryDump) const {
+    // Don't log the backing texture's contribution to the memory size. This will be handled by the
+    // texture object.
+
+    // If we have a renderbuffer and it is not auto-resolving, dump it.
+    if (fMSColorRenderbufferID && fRTFBOID != 0) {

[bsalomon, 2015/09/08 15:00:49]

A bug in similar logic was fixed recently in GrGLRenderTaret::init(). Can we add
a private method on GrGLRT to get the number of color color values per pixel to
share implementation? Or maybe a method that computes the memory size of the RT
if that can be shared?

[ericrk, 2015/09/14 21:55:54]

This isn't quite what we want to do here... we only want to log the MSAA buffer
if it exists, not log the size of the entire object (MSAA buffer + texture
resolve target), so this logic doesn't match the logic in init. It doesn't even
match the number of samples calculated in init (intentionally).

I've factored this into a couple helper functions, which I think makes things
clearer... let me know what you think.

+        size_t colorBytes = GrBytesPerPixel(fDesc.fConfig);
+        size_t size = SkTMax(1, fDesc.fSampleCnt) * fDesc.fWidth * fDesc.fHeight * colorBytes;
+
+        // Due to this resource having both a texture and a renderbuffer component, dump as
+        // skia/gpu_resources/resource_#/renderbuffer
+        SkString dumpName("skia/gpu_resources/resource_");
+        dumpName.appendS32(this->getUniqueID());
+        dumpName.append("/renderbuffer");
+
+        traceMemoryDump->dumpNumericValue(dumpName.c_str(), "size", "bytes", size);
+
+        if (this->isPurgeable()) {
+            traceMemoryDump->dumpNumericValue(dumpName.c_str(), "purgeable_size", "bytes", size);
+        }
+
+        SkString renderbuffer_id;
+        renderbuffer_id.appendU32(fMSColorRenderbufferID);
+        traceMemoryDump->setMemoryBacking(dumpName.c_str(), "gl_renderbuffer",
+                                          renderbuffer_id.c_str());
+    }
+}