Issue 1313683002: Revert of Modify GrBWFillRectBatch to use GrQuad

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1313683002: Revert of Modify GrBWFillRectBatch to use GrQuad (Closed)

Created:
5 years, 4 months ago by joshualitt

Modified:
5 years, 4 months ago

Reviewers:
bsalomon, robertphillips, joshua.litt

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of Modify GrBWFillRectBatch to use GrQuad (patchset #3 id:40001 of https://codereview.chromium.org/1311793002/ ) Reason for revert: on some bots this patch creates bad diffs Original issue's description: > Modify GrBWFillRectBatch to use GrQuad > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/c611b5afbef6df6c02e949fdf092aab2bb7e0e2e TBR=bsalomon@google.com,robertphillips@google.com,joshualitt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/26db32bc9a44aa922b4d2f4784274cd247b4890c

Patch Set 1 #

Created: 5 years, 4 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+127 lines, -87 lines)			Patch
	M	src/gpu/GrQuad.h	View		2 chunks	+0 lines, -7 lines	0 comments	Download
	M	src/gpu/batches/GrBWFillRectBatch.cpp	View		7 chunks	+127 lines, -80 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

joshualitt

Created Revert of Modify GrBWFillRectBatch to use GrQuad

5 years, 4 months ago (2015-08-24 17:25:53 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313683002/1

5 years, 4 months ago (2015-08-24 17:25:58 UTC) #2

commit-bot: I haz the power

5 years, 4 months ago (2015-08-24 17:26:04 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/26db32bc9a44aa922b4d2f4784274cd247b4890c

Expand Messages | Collapse Messages