Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1313613004: Release 1.1.2. (Closed)

Created:
5 years, 3 months ago by nweiz
Modified:
5 years, 3 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/collection@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix some flaws with the previous CL. This adds a missing import, removes an unused import, removes tests that are now irrelevant, and releases 1.1.2. R=lrn@google.com Committed: https://github.com/dart-lang/collection/commit/a41feaee6af0896d36c64f1c4a793e7bb099c6c9

Patch Set 1 #

Patch Set 2 : More fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -24 lines) Patch
M lib/src/unmodifiable_wrappers.dart View 1 1 chunk +0 lines, -2 lines 0 comments Download
M lib/wrappers.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/unmodifiable_collection_test.dart View 1 2 chunks +0 lines, -21 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
Forgot to do this in the last CL :p.
5 years, 3 months ago (2015-08-25 19:48:06 UTC) #2
Lasse Reichstein Nielsen
lgtm
5 years, 3 months ago (2015-08-26 07:27:30 UTC) #3
nweiz
5 years, 3 months ago (2015-08-26 19:22:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a41feaee6af0896d36c64f1c4a793e7bb099c6c9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698