Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 13136004: NaCl: Update revision in DEPS, r11083 -> r11094, disable pnacl in naclmore (Closed)

Created:
7 years, 8 months ago by jvoung (off chromium)
Modified:
7 years, 8 months ago
Reviewers:
Mark Seaborn
CC:
chromium-reviews, native-client-reviews_googlegroups.com, Derek Schuff, JF, jvoung - send to chromium..., Karl, Mark Seaborn, Vlad Shcherbina
Visibility:
Public.

Description

NaCl: Update revision in DEPS, r11083 -> r11094, disable pnacl in naclmore. PNaCl tests are broken by 11090. Fixing that will require some additional cross-repo naming conventions. Instead test with the existing PNaCl gyp tests and work on migrating the rest of the PNaCl related tests to Gyp. This pulls in the following Native Client changes: r11084: (shcherbina) Validator_ragel: disable CRC32 <16-bit operand>, <32-bit operand>. r11085: (shcherbina) Validator_ragel: extract action bodies and error action from XML. r11086: (jvoung) Roll pnacl tools rev to 11078 to pull in the pnacl-finalize script. r11087: (mseaborn) PNaCl: Update LLVM revision in pnacl/DEPS r11088: (kschimpf) Add ability to run ARM validation multiple times for performance testing. r11089: (dschuff) Update pnacl perf_expectations r11090: (jvoung) Add a scons pnacl finalize step for pnacl_generate_pexe tests. r11091: (kschimpf) Add ability to introduce implicit methods in the ARMv7 validator. r11092: (mseaborn) Harden Windows exception handler: Allow resuming from int3 breakpoint only once r11093: (jfb) Update PNaCl DEPS to pull in my Cortex-A9 change. r11094: (jfb) Update TOOL_REVISIONS, pull in Derek's 'PNaCl ABI: Enable resolve-aliases and nacl-global-cleanup passes'. BUG=none TEST=nacl_integration

Patch Set 1 #

Patch Set 2 : Also test the .nonfinal.pexe #

Patch Set 3 : use final.pexe #

Patch Set 4 : disable instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/nacl_test_injection/buildbot_chrome_nacl_stage.py View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jvoung (off chromium)
7 years, 8 months ago (2013-04-02 16:30:11 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698