content/common/text_input_client_messages.h - Issue 1313553006: Implement "Look Up In Dictionary" context menu item asynchronously.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/text_input_client_messages.h

Issue 1313553006: Implement "Look Up In Dictionary" context menu item asynchronously. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/render_widget_host_view_mac.mm ('K') | « content/browser/renderer_host/text_input_client_message_filter.mm ('k') | content/renderer/text_input_client_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/text_input_client_messages.h

diff --git a/content/common/text_input_client_messages.h b/content/common/text_input_client_messages.h

index 860bf10911bc920d44f284af652e56ddec83d8c6..85c6381d97167511c518ec5e52d1506025196913 100644

--- a/content/common/text_input_client_messages.h

+++ b/content/common/text_input_client_messages.h

@@ -29,10 +29,6 @@ IPC_MESSAGE_ROUTED1(TextInputClientMsg_CharacterIndexForPoint,

IPC_MESSAGE_ROUTED1(TextInputClientMsg_FirstRectForCharacterRange,

gfx::Range)

-// Tells the renderer to send back the text fragment in a given range.

-IPC_MESSAGE_ROUTED1(TextInputClientMsg_StringForRange,

- gfx::Range)

// Tells the renderer to send back the word under the given point and its

// baseline point.

IPC_MESSAGE_ROUTED1(TextInputClientMsg_StringAtPoint, gfx::Point)

@@ -52,10 +48,6 @@ IPC_MESSAGE_ROUTED1(TextInputClientReplyMsg_GotFirstRectForRange,

gfx::Rect /* frame rectangle */)

#if defined(OS_MACOSX)

-// Reply message for TextInputClientMsg_StringForRange.

-IPC_MESSAGE_ROUTED1(TextInputClientReplyMsg_GotStringForRange,

- mac::AttributedStringCoder::EncodedString)

// Reply message for TextInputClientMsg_StringAtPoint

IPC_MESSAGE_ROUTED2(TextInputClientReplyMsg_GotStringAtPoint,

mac::AttributedStringCoder::EncodedString,