content/browser/renderer_host/text_input_client_message_filter.mm - Issue 1313553006: Implement "Look Up In Dictionary" context menu item asynchronously.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/text_input_client_message_filter.mm

Issue 1313553006: Implement "Look Up In Dictionary" context menu item asynchronously. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/render_widget_host_view_mac.mm ('K') | « content/browser/renderer_host/text_input_client_message_filter.h ('k') | content/common/text_input_client_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/text_input_client_message_filter.mm

diff --git a/content/browser/renderer_host/text_input_client_message_filter.mm b/content/browser/renderer_host/text_input_client_message_filter.mm

index 090daaa522da775d882171ee5a52ffb623bbee36..5abde0d8c565596b901d2335510d30a5750b1adc 100644

--- a/content/browser/renderer_host/text_input_client_message_filter.mm

+++ b/content/browser/renderer_host/text_input_client_message_filter.mm

@@ -30,8 +30,6 @@ bool TextInputClientMessageFilter::OnMessageReceived(

OnGotCharacterIndexForPoint)

IPC_MESSAGE_HANDLER(TextInputClientReplyMsg_GotFirstRectForRange,

OnGotFirstRectForRange)

- IPC_MESSAGE_HANDLER(TextInputClientReplyMsg_GotStringForRange,

- OnGotStringFromRange)

IPC_MESSAGE_UNHANDLED(handled = false)

IPC_END_MESSAGE_MAP()

return handled;

@@ -64,14 +62,4 @@ void TextInputClientMessageFilter::OnGotFirstRectForRange(

service->SetFirstRectAndSignal(NSRectFromCGRect(rect.ToCGRect()));

}

-void TextInputClientMessageFilter::OnGotStringFromRange(

- const mac::AttributedStringCoder::EncodedString& encoded_string) {

- TextInputClientMac* service = TextInputClientMac::GetInstance();

- NSAttributedString* string =

- mac::AttributedStringCoder::Decode(&encoded_string);

- if (![string length])

- string = nil;

- service->SetSubstringAndSignal(string);

} // namespace content