Issue 1313543002: Fix style checker errors after https://codereview.chromium.org/1263403002/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1313543002: Fix style checker errors after https://codereview.chromium.org/1263403002/ (Closed)

Created:
5 years, 4 months ago by Nico

Modified:
5 years, 3 months ago

Reviewers:
Mike Wittman

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Fix style checker errors after https://codereview.chromium.org/1263403002/ Functions marked 'override' should not be marked 'virtual' also. BUG=82385, 516402 TBR=wittman

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -5 lines)			Patch
	M	base/profiler/win32_stack_frame_unwinder.h	View		1 chunk	+6 lines, -5 lines	0 comments	Download

Total messages: 4 (1 generated)

Nico

Committed patchset #1 (id:1) to pending queue manually as 6c28e1fbefa0c63c23159602b7d9073496fdc334 (presubmit successful).

5 years, 4 months ago (2015-08-24 03:35:01 UTC) #3

Message was sent while issue was closed.

lgtm

Thanks for the fix.