DescriptionFix reftest crash logs
This patch fixes a long-standing bug where crashing reftests would not
show some crash logs on the layout tests results page.
single_test_runner.py has an optimization to not run reftests when
the base test crashes. This optimization accidentally failed to write
crash logs (done through write_test_result(...)) as well. This patch
fixes this bug and adds a small test.
This is a reland of https://codereview.chromium.org/1312693002 which
was rolled out due to crashes on Win10 (see http://crbug.com/524248#50).
This patch has two potential fixes for the crashes seen before:
1) test results are only written for crash tests, not timeouts.
2) The non-null expected_driver_output is used in the call for
write_test_result instead of reference_output which is null and
caused asserts.
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201827
Patch Set 1 #
Messages
Total messages: 10 (4 generated)
|