Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1313533004: Fix reftest crash logs (Closed)

Created:
5 years, 3 months ago by pdr.
Modified:
5 years, 3 months ago
Reviewers:
Dirk Pranke, estaab
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix reftest crash logs This patch fixes a long-standing bug where crashing reftests would not show some crash logs on the layout tests results page. single_test_runner.py has an optimization to not run reftests when the base test crashes. This optimization accidentally failed to write crash logs (done through write_test_result(...)) as well. This patch fixes this bug and adds a small test. This is a reland of https://codereview.chromium.org/1312693002 which was rolled out due to crashes on Win10 (see http://crbug.com/524248#50). This patch has two potential fixes for the crashes seen before: 1) test results are only written for crash tests, not timeouts. 2) The non-null expected_driver_output is used in the call for write_test_result instead of reference_output which is null and caused asserts. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201827

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py View 1 chunk +5 lines, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/test.py View 1 chunk +6 lines, -0 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313533004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313533004/1
5 years, 3 months ago (2015-09-04 05:05:35 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-04 05:46:31 UTC) #4
pdr.
@dpranke, I'm the gardener today and would like to try relanding this. I've updated the ...
5 years, 3 months ago (2015-09-04 17:32:15 UTC) #6
Dirk Pranke
lgtm
5 years, 3 months ago (2015-09-04 22:21:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313533004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313533004/1
5 years, 3 months ago (2015-09-04 22:22:39 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 22:27:20 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201827

Powered by Google App Engine
This is Rietveld 408576698