Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1312693002: Fix reftest crash logs (Closed)

Created:
5 years, 4 months ago by pdr.
Modified:
5 years, 4 months ago
Reviewers:
Dirk Pranke, joelo, ojan
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix reftest crash logs This patch fixes a long-standing bug where crashing reftests would not show some crash logs on the layout tests results page. single_test_runner.py has an optimization to not run reftests when the base test crashes. This optimization accidentally failed to write crash logs (done through write_test_result(...)) as well. This patch fixes this bug and adds a small test. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201147

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py View 1 chunk +3 lines, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/test.py View 1 chunk +6 lines, -0 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
pdr.
5 years, 4 months ago (2015-08-23 03:41:13 UTC) #2
Dirk Pranke
lgtm, thanks! (and sorry for the delay, was ooo ...)
5 years, 4 months ago (2015-08-25 19:36:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312693002/1
5 years, 4 months ago (2015-08-25 19:44:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=201147
5 years, 4 months ago (2015-08-25 20:24:48 UTC) #6
pdr.
5 years, 3 months ago (2015-08-26 21:38:37 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1318813005/ by pdr@chromium.org.

The reason for reverting is: May be causing win failures, see
http://crbug.com/524248#50.

Powered by Google App Engine
This is Rietveld 408576698