Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1313423002: make cacherator thread-safe (Closed)

Created:
5 years, 3 months ago by reed1
Modified:
5 years, 3 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

make cacherator thread-safe hoisted from https://codereview.chromium.org/1282363002 as that CL is going to take a while to finish BUG=skia: TBR= Committed: https://skia.googlesource.com/skia/+/d5c448fd857a77a375886bc1a8da83a7f1bf32fe

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -40 lines) Patch
M src/core/SkImageCacherator.h View 3 chunks +25 lines, -4 lines 0 comments Download
M src/core/SkImageCacherator.cpp View 1 2 6 chunks +53 lines, -36 lines 1 comment Download

Messages

Total messages: 15 (6 generated)
reed1
5 years, 3 months ago (2015-08-26 20:42:21 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313423002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313423002/20001
5 years, 3 months ago (2015-08-26 20:42:38 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/2829) Build-Ubuntu-Clang-x86_64-Debug-Trybot on ...
5 years, 3 months ago (2015-08-26 20:43:19 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313423002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313423002/60001
5 years, 3 months ago (2015-08-26 21:08:29 UTC) #8
reed1
Lets look at using Lambdas separately (need to understand how to return diff types, templates?)
5 years, 3 months ago (2015-08-26 21:09:54 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/2900)
5 years, 3 months ago (2015-08-26 21:10:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313423002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313423002/60001
5 years, 3 months ago (2015-08-26 21:14:30 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://skia.googlesource.com/skia/+/d5c448fd857a77a375886bc1a8da83a7f1bf32fe
5 years, 3 months ago (2015-08-26 21:16:47 UTC) #14
mtklein
5 years, 3 months ago (2015-08-26 21:20:57 UTC) #15
Message was sent while issue was closed. 
sg.  this lgtm

https://codereview.chromium.org/1313423002/diff/60001/src/core/SkImageCachera...
File src/core/SkImageCacherator.cpp (right):

https://codereview.chromium.org/1313423002/diff/60001/src/core/SkImageCachera...
src/core/SkImageCacherator.cpp:185: // 2. Ask the genreator to natively create
one
Out of curiosity, will each of these 2-5 lock then unlock the generator? 
That'll work fine, of course, but we might want to think about arranging it so
that we lock once around the whole deal and just have each step assert we're
holding the lock.  Will probably become clearer as this is used more and we fill
in 3+4.

Powered by Google App Engine
This is Rietveld 408576698