chrome/browser/about_flags.cc - Issue 1313383006: Don't compile save_password_infobar_delegate.cc everywhere but Mac and Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/about_flags.cc

Issue 1313383006: Don't compile save_password_infobar_delegate.cc everywhere but Mac and Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Exclude kEnableSavePasswordBubble/kDisableSavePasswordBubble definitions on Aura platforms Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « AUTHORS ('k') | chrome/browser/password_manager/chrome_password_manager_client.cc » ('j') | chrome/browser/password_manager/chrome_password_manager_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/about_flags.cc

diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc

index 58ff3a4c7972d5d36ae1bf7cf6b6f2c068c58c29..9c5244c0d5a94d185b431a34ac97b5d66cfc880c 100644

--- a/chrome/browser/about_flags.cc

+++ b/chrome/browser/about_flags.cc

@@ -1578,12 +1578,14 @@ const Experiment kExperiments[] = {

kOsDesktop,

ENABLE_DISABLE_VALUE_TYPE(switches::kEnableSettingsWindow,

switches::kDisableSettingsWindow)},

+#if !defined(USE_AURA)

vabr (Chromium) 2015/09/10 07:21:47 Note that Win, Linux and CrOS always have Aura def

ki.stfu 2015/09/10 18:21:00 Done.

{"enable-save-password-bubble",

IDS_FLAGS_ENABLE_SAVE_PASSWORD_BUBBLE_NAME,

IDS_FLAGS_ENABLE_SAVE_PASSWORD_BUBBLE_DESCRIPTION,

- kOsWin | kOsLinux | kOsCrOS | kOsMac,

+ kOsWin | kOsLinux | kOsCrOS,

ENABLE_DISABLE_VALUE_TYPE(switches::kEnableSavePasswordBubble,

switches::kDisableSavePasswordBubble)},

+#endif

{"enable-apps-file-associations",

IDS_FLAGS_ENABLE_APPS_FILE_ASSOCIATIONS_NAME,

IDS_FLAGS_ENABLE_APPS_FILE_ASSOCIATIONS_DESCRIPTION,