Don't compile save_password_infobar_delegate.cc everywhere but Mac and Android

chrome/browser/about_flags.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/about_flags.h"
 
 #include <iterator>
 #include <map>
 #include <set>
 #include <utility>
@@ skipping 1560 matching lines @@
      IDS_FLAGS_BLEEDING_RENDERER_NAME,
      IDS_FLAGS_BLEEDING_RENDERER_DESCRIPTION,
      kOsAndroid,
      SINGLE_VALUE_TYPE(switches::kEnableBleedingEdgeRenderingFastPaths)},
     {"enable-settings-window",
      IDS_FLAGS_ENABLE_SETTINGS_WINDOW_NAME,
      IDS_FLAGS_ENABLE_SETTINGS_WINDOW_DESCRIPTION,
      kOsDesktop,
      ENABLE_DISABLE_VALUE_TYPE(switches::kEnableSettingsWindow,
                                switches::kDisableSettingsWindow)},
+#if !defined(USE_AURA)

[vabr (Chromium), 2015/09/10 07:21:47]

Note that Win, Linux and CrOS always have Aura defined, so the current code does
not enable the flag at all.

What we wanted was to enable the flag only on Mac (independent of whether Aura
or Mac native UI support is used), so I suggest
#if defined(OS_MACOSX)
and
changing line 1585 to just kOsMac.

[ki.stfu, 2015/09/10 18:21:00]

Done.

     {"enable-save-password-bubble",
      IDS_FLAGS_ENABLE_SAVE_PASSWORD_BUBBLE_NAME,
      IDS_FLAGS_ENABLE_SAVE_PASSWORD_BUBBLE_DESCRIPTION,
-     kOsWin | kOsLinux | kOsCrOS | kOsMac,
+     kOsWin | kOsLinux | kOsCrOS,
      ENABLE_DISABLE_VALUE_TYPE(switches::kEnableSavePasswordBubble,
                                switches::kDisableSavePasswordBubble)},
+#endif
     {"enable-apps-file-associations",
      IDS_FLAGS_ENABLE_APPS_FILE_ASSOCIATIONS_NAME,
      IDS_FLAGS_ENABLE_APPS_FILE_ASSOCIATIONS_DESCRIPTION,
      kOsMac,
      SINGLE_VALUE_TYPE(switches::kEnableAppsFileAssociations)},
 #if defined(OS_ANDROID)
     {"enable-embeddedsearch-api",
      IDS_FLAGS_ENABLE_EMBEDDEDSEARCH_API_NAME,
      IDS_FLAGS_ENABLE_EMBEDDEDSEARCH_API_DESCRIPTION,
      kOsAndroid,
@@ skipping 1119 matching lines @@
 }
 
 const Experiment* GetExperiments(size_t* count) {
   *count = num_experiments;
   return experiments;
 }
 
 }  // namespace testing
 
 }  // namespace about_flags