Don't compile save_password_infobar_delegate.cc everywhere but Mac and Android

chrome/chrome_browser.gypi

Index: chrome/chrome_browser.gypi
diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi
index d13ff31d47a31a2c80b6a37a0c9644442b41a807..6fb1e75adfb7d8fccf00068277dd451c10e1c36c 100644
--- a/chrome/chrome_browser.gypi
+++ b/chrome/chrome_browser.gypi
@@ -2068,11 +2068,14 @@
       'browser/password_manager/password_store_win.h',
       'browser/password_manager/password_store_x.cc',
       'browser/password_manager/password_store_x.h',
-      'browser/password_manager/save_password_infobar_delegate.cc',
-      'browser/password_manager/save_password_infobar_delegate.h',
       'browser/password_manager/simple_password_store_mac.cc',
       'browser/password_manager/simple_password_store_mac.h',
     ],
+    # Used on Mac and Android platforms.
+    'chrome_browser_password_manager_mac_android_sources': [
+      'browser/password_manager/save_password_infobar_delegate.cc',

[Evan Stade, 2015/09/16 00:05:06]

optional nit: It doesn't seem like this configuration (mac and android only) is
going to be very popular so maybe follow the model of
browser/net/disk_cache_dir_policy_handler.cc (just a custom condition, no
special list).

[ki.stfu, 2015/09/16 08:17:30]

It's done not because of popularity of that configuration. As for me, it's a bit
clearer than just adding files in conditions.

+      'browser/password_manager/save_password_infobar_delegate.h',
+    ],
     'chrome_browser_permissions_sources': [
       'browser/permissions/permission_bubble_request_impl.cc',
       'browser/permissions/permission_bubble_request_impl.h',
@@ -3395,6 +3398,11 @@
           ],
           'sources': [ '<@(chrome_browser_mac_sources)' ]
         }],
+        ['OS=="mac" or OS=="android"', {
+          'sources': [
+            '<@(chrome_browser_password_manager_mac_android_sources)',
+          ],
+        }],
         ['chromeos==1', {
           'sources!': [
             'browser/metrics/signin_status_metrics_provider.cc',