Don't compile save_password_infobar_delegate.cc everywhere but Mac and Android

chrome/chrome_browser.gypi

 # Copyright 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     # All .cc, .h, .m, and .mm files under browser except for:
     # * tests and mocks.
     # * code below browser/chromeos
     # * code below browser/extensions
@@ skipping 2050 matching lines @@
       'browser/password_manager/password_store_factory.h',
       'browser/password_manager/password_store_mac.cc',
       'browser/password_manager/password_store_mac.h',
       'browser/password_manager/password_store_mac_internal.h',
       'browser/password_manager/password_store_proxy_mac.cc',
       'browser/password_manager/password_store_proxy_mac.h',
       'browser/password_manager/password_store_win.cc',
       'browser/password_manager/password_store_win.h',
       'browser/password_manager/password_store_x.cc',
       'browser/password_manager/password_store_x.h',
+      'browser/password_manager/simple_password_store_mac.cc',
+      'browser/password_manager/simple_password_store_mac.h',
+    ],
+    # Used on Mac and Android platforms.
+    'chrome_browser_password_manager_mac_android_sources': [
       'browser/password_manager/save_password_infobar_delegate.cc',

[Evan Stade, 2015/09/16 00:05:06]

optional nit: It doesn't seem like this configuration (mac and android only) is
going to be very popular so maybe follow the model of
browser/net/disk_cache_dir_policy_handler.cc (just a custom condition, no
special list).

[ki.stfu, 2015/09/16 08:17:30]

It's done not because of popularity of that configuration. As for me, it's a bit
clearer than just adding files in conditions.

       'browser/password_manager/save_password_infobar_delegate.h',
-      'browser/password_manager/simple_password_store_mac.cc',
-      'browser/password_manager/simple_password_store_mac.h',
     ],
     'chrome_browser_permissions_sources': [
       'browser/permissions/permission_bubble_request_impl.cc',
       'browser/permissions/permission_bubble_request_impl.h',
       'browser/permissions/permission_context.cc',
       'browser/permissions/permission_context.h',
       'browser/permissions/permission_context_base.cc',
       'browser/permissions/permission_context_base.h',
       'browser/permissions/permission_context_uma_util.cc',
       'browser/permissions/permission_context_uma_util.h',
@@ skipping 1303 matching lines @@
             'browser/download/download_dir_policy_handler.h',
           ],
         }],
         ['OS=="mac"', {
           'dependencies': [
             'app_shim',
             'browser_app_shim',
           ],
           'sources': [ '<@(chrome_browser_mac_sources)' ]
         }],
+        ['OS=="mac" or OS=="android"', {
+          'sources': [
+            '<@(chrome_browser_password_manager_mac_android_sources)',
+          ],
+        }],
         ['chromeos==1', {
           'sources!': [
             'browser/metrics/signin_status_metrics_provider.cc',
             'browser/metrics/signin_status_metrics_provider.h',
           ],
         }],
         ['enable_extensions==1', {
           'dependencies': [
             'browser_extensions',
             'browser/extensions/api/api_registration.gyp:chrome_api_registration',
@@ skipping 715 matching lines @@
             '../components/components.gyp:omnibox_browser',
             '../components/components.gyp:rlz',
             '../components/components.gyp:search_engines',
             '../rlz/rlz.gyp:rlz_lib',
           ],
         },
       ],
     }],
   ],
 }