Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1322)

Unified Diff: content/child/notifications/notification_data_conversions_unittest.cc

Issue 1313363006: Plumb requireInteraction to PlatformNotificationData & database (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@constructor
Patch Set: Fix includes Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/notifications/notification_data_conversions_unittest.cc
diff --git a/content/child/notifications/notification_data_conversions_unittest.cc b/content/child/notifications/notification_data_conversions_unittest.cc
index 11ca1f20152f14a5ef8850a504499b30fd8faec8..93e247d197251aac895c58cc298b44cdddad726a 100644
--- a/content/child/notifications/notification_data_conversions_unittest.cc
+++ b/content/child/notifications/notification_data_conversions_unittest.cc
@@ -39,6 +39,7 @@ TEST(NotificationDataConversionsTest, ToPlatformNotificationData) {
web_data.vibrate = blink::WebVector<int>(
kNotificationVibrationPattern, arraysize(kNotificationVibrationPattern));
web_data.silent = true;
+ web_data.requireInteraction = true;
web_data.data = blink::WebVector<char>(kNotificationData,
arraysize(kNotificationData));
@@ -58,6 +59,7 @@ TEST(NotificationDataConversionsTest, ToPlatformNotificationData) {
EXPECT_EQ(kNotificationTag, platform_data.tag);
EXPECT_EQ(kNotificationIconUrl, platform_data.icon.spec());
EXPECT_TRUE(platform_data.silent);
+ EXPECT_TRUE(platform_data.require_interaction);
EXPECT_THAT(platform_data.vibration_pattern,
testing::ElementsAreArray(kNotificationVibrationPattern));
@@ -90,6 +92,7 @@ TEST(NotificationDataConversionsTest, ToWebNotificationData) {
platform_data.icon = GURL(kNotificationIconUrl);
platform_data.vibration_pattern = vibration_pattern;
platform_data.silent = true;
+ platform_data.require_interaction = true;
platform_data.data = developer_data;
platform_data.actions.resize(2);
platform_data.actions[0].action = kAction1Name;
@@ -111,6 +114,7 @@ TEST(NotificationDataConversionsTest, ToWebNotificationData) {
EXPECT_EQ(vibration_pattern[i], web_data.vibrate[i]);
EXPECT_TRUE(web_data.silent);
+ EXPECT_TRUE(web_data.requireInteraction);
ASSERT_EQ(developer_data.size(), web_data.data.size());
for (size_t i = 0; i < developer_data.size(); ++i)
« no previous file with comments | « content/child/notifications/notification_data_conversions.cc ('k') | content/common/platform_notification_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698