Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4011)

Unified Diff: chrome/browser/notifications/platform_notification_service_impl.cc

Issue 1313363006: Plumb requireInteraction to PlatformNotificationData & database (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@constructor
Patch Set: Make set_never_timeout conditional on require_interaction Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/notifications/notification_database_data.proto » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/notifications/platform_notification_service_impl.cc
diff --git a/chrome/browser/notifications/platform_notification_service_impl.cc b/chrome/browser/notifications/platform_notification_service_impl.cc
index 560fa06a4895842b35789cd800836a542d8ee8fb..60f432f35cd100803dd3eb457fbe1cb846291709 100644
--- a/chrome/browser/notifications/platform_notification_service_impl.cc
+++ b/chrome/browser/notifications/platform_notification_service_impl.cc
@@ -343,8 +343,11 @@ Notification PlatformNotificationServiceImpl::CreateNotificationFromData(
notification.set_buttons(buttons);
- // Web Notifications do not timeout.
- notification.set_never_timeout(true);
+ // On desktop, notifications with require_interaction==true stay on-screen
+ // rather than minimizing to the notification center after a timeout.
+ // On mobile, this is ignored (notifications are minimized at all times).
+ if (notification_data.require_interaction)
Peter Beverloo 2015/08/28 14:17:54 We can't do this. The feature is still marked as
+ notification.set_never_timeout(true);
return notification;
}
« no previous file with comments | « no previous file | content/browser/notifications/notification_database_data.proto » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698