Overhaul Mandoline event transport code

components/pdf_viewer/pdf_viewer.cc

Index: components/pdf_viewer/pdf_viewer.cc
diff --git a/components/pdf_viewer/pdf_viewer.cc b/components/pdf_viewer/pdf_viewer.cc
index 730ce3a27ea6be565f127a52b1d7e68d5feec614..bb228cab3e3084cb2cdea06f51a3972ec7019839 100644
--- a/components/pdf_viewer/pdf_viewer.cc
+++ b/components/pdf_viewer/pdf_viewer.cc
@@ -372,9 +372,13 @@ class PDFView : public mojo::ApplicationDelegate,
       return;
     }
 
+    // TODO(rjkroege): Make panning and scrolling more performant and
+    // responsive to gesture events.
     if ((event->key_data &&
          event->key_data->windows_key_code == mojo::KEYBOARD_CODE_DOWN) ||
-        (event->pointer_data && event->pointer_data->vertical_wheel < 0)) {
+        (event->pointer_data &&
+         event->pointer_data->kind == mojo::POINTER_KIND_WHEEL &&

[sadrul, 2015/09/09 04:19:04]

It should be possible to look at event->action, instead of pointer_data->kind to
decide if this is a wheel event I think.

Unrelated to this CL: this looks ... curious. Do we switch pages in a pdf for
each mouse-wheel event?

[rjkroege, 2015/09/12 01:29:02]

Done.
yes. Fixed.


Resolving this blocked on http://crbug.com/530268

+         event->pointer_data->wheel_data->delta_y < 0)) {
       if (current_page_ < (page_count_ - 1)) {
         current_page_++;
         DrawBitmap(embedder_for_roots_[view]);
@@ -382,7 +386,8 @@ class PDFView : public mojo::ApplicationDelegate,
     } else if ((event->key_data &&
                 event->key_data->windows_key_code == mojo::KEYBOARD_CODE_UP) ||
                (event->pointer_data &&
-                event->pointer_data->vertical_wheel > 0)) {
+                event->pointer_data->kind == mojo::POINTER_KIND_WHEEL &&
+                event->pointer_data->wheel_data->delta_y > 0)) {
       if (current_page_ > 0) {
         current_page_--;
         DrawBitmap(embedder_for_roots_[view]);