Overhaul Mandoline event transport code

components/pdf_viewer/pdf_viewer.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/containers/hash_tables.h"
 #include "base/memory/scoped_ptr.h"
 #include "components/view_manager/public/cpp/types.h"
 #include "components/view_manager/public/cpp/view.h"
@@ skipping 354 matching lines @@
 
   void OnViewInputEvent(mojo::View* view,
                         const mojo::EventPtr& event) override {
     DCHECK(embedder_for_roots_.find(view) != embedder_for_roots_.end());
     if (event->key_data &&
         (event->action != mojo::EVENT_TYPE_KEY_PRESSED ||
          event->key_data->is_char)) {
       return;
     }
 
+    // TODO(rjkroege): Make panning and scrolling more performant and
+    // responsive to gesture events.
     if ((event->key_data &&
          event->key_data->windows_key_code == mojo::KEYBOARD_CODE_DOWN) ||
-        (event->pointer_data && event->pointer_data->vertical_wheel < 0)) {
+        (event->pointer_data &&
+         event->pointer_data->kind == mojo::POINTER_KIND_WHEEL &&

[sadrul, 2015/09/09 04:19:04]

It should be possible to look at event->action, instead of pointer_data->kind to
decide if this is a wheel event I think.

Unrelated to this CL: this looks ... curious. Do we switch pages in a pdf for
each mouse-wheel event?

[rjkroege, 2015/09/12 01:29:02]

Done.
yes. Fixed.


Resolving this blocked on http://crbug.com/530268

+         event->pointer_data->wheel_data->delta_y < 0)) {
       if (current_page_ < (page_count_ - 1)) {
         current_page_++;
         DrawBitmap(embedder_for_roots_[view]);
       }
     } else if ((event->key_data &&
                 event->key_data->windows_key_code == mojo::KEYBOARD_CODE_UP) ||
                (event->pointer_data &&
-                event->pointer_data->vertical_wheel > 0)) {
+                event->pointer_data->kind == mojo::POINTER_KIND_WHEEL &&
+                event->pointer_data->wheel_data->delta_y > 0)) {
       if (current_page_ > 0) {
         current_page_--;
         DrawBitmap(embedder_for_roots_[view]);
       }
     }
   }
 
   void OnViewDestroyed(mojo::View* view) override {
     DCHECK(embedder_for_roots_.find(view) != embedder_for_roots_.end());
     const auto& it = embedder_for_roots_.find(view);
@@ skipping 109 matching lines @@
   DISALLOW_COPY_AND_ASSIGN(PDFViewer);
 };
 
 }  // namespace
 }  // namespace pdf_viewer
 
 MojoResult MojoMain(MojoHandle application_request) {
   mojo::ApplicationRunner runner(new pdf_viewer::PDFViewer());
   return runner.Run(application_request);
 }