Check for cyclic type variable bounds.

Check for cyclic type variable bounds.

This CL uses the post-processing queue introduced in CL https://codereview.chromium.org/13261008/.

Committed: https://code.google.com/p/dart/source/detail?r=21055

[ahe, 2013-04-02 08:28:06]

There is something wrong with the diff.  It contains parts from CL 13261008.

When using git cl upload, provide an argument, namely the branch name of CL
13261008, for example, if the branch for 13261008 is named cyclic_typedef:

git cl upload cyclic_typedef

[Johnni Winther, 2013-04-02 09:02:19]

On 2013/04/02 08:28:06, ahe wrote:
> There is something wrong with the diff.  It contains parts from CL 13261008.
> 
> When using git cl upload, provide an argument, namely the branch name of CL
> 13261008, for example, if the branch for 13261008 is named cyclic_typedef:
> 
> git cl upload cyclic_typedef

Fixed. PTAL

[ahe, 2013-04-02 09:08:16]

LGTM

https://codereview.chromium.org/13133006/diff/6001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/warnings.dart (right):

https://codereview.chromium.org/13133006/diff/6001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/warnings.dart:194: "type variable
#{typeVariableName} is a supertype of its upper bound");
How about: "is a supertype of itself"

https://codereview.chromium.org/13133006/diff/6001/tests/compiler/dart2js/typ...
File tests/compiler/dart2js/type_variable_bound_test.dart (right):

https://codereview.chromium.org/13133006/diff/6001/tests/compiler/dart2js/typ...
tests/compiler/dart2js/type_variable_bound_test.dart:25:
Expect.isTrue(compiler.errors.isEmpty, 'unexpected errors');
You could delete line 24 if you use this:

'unexpected errors: ${compiler.errors}'

https://codereview.chromium.org/13133006/diff/6001/tests/compiler/dart2js/typ...
tests/compiler/dart2js/type_variable_bound_test.dart:27: 'expected exactly one
error, but got ${compiler.warnings}');
"one error" -> "one warning"

https://codereview.chromium.org/13133006/diff/6001/tests/compiler/dart2js/typ...
tests/compiler/dart2js/type_variable_bound_test.dart:117: 
Extra lines.

[Johnni Winther, 2013-04-02 12:53:48]

https://codereview.chromium.org/13133006/diff/6001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/warnings.dart (right):

https://codereview.chromium.org/13133006/diff/6001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/warnings.dart:194: "type variable
#{typeVariableName} is a supertype of its upper bound");
On 2013/04/02 09:08:16, ahe wrote:
> How about: "is a supertype of itself"

Done.

https://codereview.chromium.org/13133006/diff/6001/tests/compiler/dart2js/typ...
File tests/compiler/dart2js/type_variable_bound_test.dart (right):

https://codereview.chromium.org/13133006/diff/6001/tests/compiler/dart2js/typ...
tests/compiler/dart2js/type_variable_bound_test.dart:25:
Expect.isTrue(compiler.errors.isEmpty, 'unexpected errors');
On 2013/04/02 09:08:16, ahe wrote:
> You could delete line 24 if you use this:
> 
> 'unexpected errors: ${compiler.errors}'

Done.

https://codereview.chromium.org/13133006/diff/6001/tests/compiler/dart2js/typ...
tests/compiler/dart2js/type_variable_bound_test.dart:27: 'expected exactly one
error, but got ${compiler.warnings}');
On 2013/04/02 09:08:16, ahe wrote:
> "one error" -> "one warning"

Done.

https://codereview.chromium.org/13133006/diff/6001/tests/compiler/dart2js/typ...
tests/compiler/dart2js/type_variable_bound_test.dart:117: 
On 2013/04/02 09:08:16, ahe wrote:
> Extra lines.

Done.

[Johnni Winther, 2013-04-08 10:22:53]

Committed patchset #5 manually as r21055 (presubmit successful).