Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart

Issue 13133006: Check for cyclic type variable bounds. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rebased + pull in PostProcess code. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart
diff --git a/sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart b/sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart
index d23b1e438cc87a3ecf281c0ed5e76e9877d7d8a7..1d90d6a9a38d452df3b7a34248fb9dcb36c09b74 100644
--- a/sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart
+++ b/sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart
@@ -465,16 +465,6 @@ class ArgumentCollector extends DartTypeVisitor {
type.accept(this, false);
}
- visit(DartType type) {
- type.accept(this, true);
- }
-
- visitList(Link<DartType> types) {
- for (Link<DartType> link = types; !link.isEmpty; link = link.tail) {
- link.head.accept(this, true);
- }
- }
-
visitType(DartType type, _) {
// Do nothing.
}
@@ -487,13 +477,10 @@ class ArgumentCollector extends DartTypeVisitor {
if (isTypeArgument) {
classes.add(type.element);
}
- visitList(type.typeArguments);
+ type.visitChildren(this, true);
}
visitFunctionType(FunctionType type, _) {
- visit(type.returnType);
- visitList(type.parameterTypes);
- visitList(type.optionalParameterTypes);
- visitList(type.namedParameterTypes);
+ type.visitChildren(this, true);
}
}

Powered by Google App Engine
This is Rietveld 408576698