Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: tools/telemetry/telemetry/internal/results/story_run_unittest.py

Issue 1313243003: [Telemetry] Introduce SummarizableValue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/internal/results/story_run_unittest.py
diff --git a/tools/telemetry/telemetry/internal/results/story_run_unittest.py b/tools/telemetry/telemetry/internal/results/story_run_unittest.py
index f4154f2ffef186b20f0617fcd4e8c35e0988d8e3..bb93eed8763deac7ee0140fd6540e1612b5484bc 100644
--- a/tools/telemetry/telemetry/internal/results/story_run_unittest.py
+++ b/tools/telemetry/telemetry/internal/results/story_run_unittest.py
@@ -9,6 +9,7 @@ from telemetry.story import shared_state
from telemetry.story import story_set
from telemetry import story as story_module
from telemetry.value import failure
+from telemetry.value import improvement_direction
from telemetry.value import scalar
from telemetry.value import skip
@@ -39,7 +40,9 @@ class StoryRunTest(unittest.TestCase):
self.assertFalse(run.skipped)
run = story_run.StoryRun(self.stories[0])
- run.AddValue(scalar.ScalarValue(self.stories[0], 'a', 's', 1))
+ run.AddValue(scalar.ScalarValue(
+ self.stories[0], 'a', 's', 1,
+ improvement_direction=improvement_direction.UP))
run.AddValue(failure.FailureValue.FromMessage(self.stories[0], 'test'))
self.assertFalse(run.ok)
self.assertTrue(run.failed)
@@ -54,7 +57,9 @@ class StoryRunTest(unittest.TestCase):
self.assertTrue(run.skipped)
run = story_run.StoryRun(self.stories[0])
- run.AddValue(scalar.ScalarValue(self.stories[0], 'a', 's', 1))
+ run.AddValue(scalar.ScalarValue(
+ self.stories[0], 'a', 's', 1,
+ improvement_direction=improvement_direction.UP))
run.AddValue(skip.SkipValue(self.stories[0], 'test'))
self.assertFalse(run.ok)
self.assertFalse(run.failed)
@@ -67,7 +72,9 @@ class StoryRunTest(unittest.TestCase):
self.assertFalse(run.skipped)
run = story_run.StoryRun(self.stories[0])
- run.AddValue(scalar.ScalarValue(self.stories[0], 'a', 's', 1))
+ run.AddValue(scalar.ScalarValue(
+ self.stories[0], 'a', 's', 1,
+ improvement_direction=improvement_direction.UP))
self.assertTrue(run.ok)
self.assertFalse(run.failed)
self.assertFalse(run.skipped)

Powered by Google App Engine
This is Rietveld 408576698