Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1313153002: Docs: theme_creation_guide.md (Closed)

Created:
5 years, 4 months ago by nodir
Modified:
5 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Docs: theme_creation_guide.md Restructured and restyled the doc. R=phistuck@chromium.org, andybons@chromium.org BUG=524256 Committed: https://crrev.com/182b21bbc850a899f3999f7d48a2adccebe02360 Cr-Commit-Position: refs/heads/master@{#345654}

Patch Set 1 #

Patch Set 2 : deleted #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -353 lines) Patch
M docs/theme_creation_guide.md View 1 1 chunk +0 lines, -353 lines 0 comments Download

Messages

Total messages: 13 (1 generated)
nodir
phistuck, PTAL Preview: https://chromium.googlesource.com/chromium/src/+/001fa7b9206c12d9cea53cea3a46abe9c0385489/docs/theme_creation_guide.md
5 years, 4 months ago (2015-08-25 16:59:13 UTC) #1
PhistucK
This may be redundant, now that there is are theme creators, for example - https://chrome.google.com/webstore/detail/theme-creator/akpelnjfckgfiplcikojhomllgombffc?hl=en
5 years, 4 months ago (2015-08-25 17:06:38 UTC) #2
PhistucK
On 2015/08/25 at 17:06:38, PhistucK wrote: > This may be redundant, now that there is ...
5 years, 4 months ago (2015-08-25 17:07:07 UTC) #3
nodir
sigh. OK, I will delete it
5 years, 4 months ago (2015-08-25 17:19:17 UTC) #4
nodir
PTAL, deleted
5 years, 4 months ago (2015-08-25 17:20:12 UTC) #5
PhistucK
Looks like it is just empty and not deleted (M and not D)?
5 years, 4 months ago (2015-08-25 17:21:41 UTC) #6
nodir
Rietveld probably does not distinguish them, it is deleted locally. I believe apply_patch will actually ...
5 years, 4 months ago (2015-08-25 17:23:16 UTC) #7
PhistucK
Looks good to me, then. ;)
5 years, 4 months ago (2015-08-25 17:23:57 UTC) #8
Bons
On 2015/08/25 17:23:57, PhistucK wrote: > Looks good to me, then. ;) lgtm
5 years, 3 months ago (2015-08-26 19:35:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313153002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313153002/20001
5 years, 3 months ago (2015-08-26 20:03:05 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-08-26 20:16:51 UTC) #12
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 20:17:37 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/182b21bbc850a899f3999f7d48a2adccebe02360
Cr-Commit-Position: refs/heads/master@{#345654}

Powered by Google App Engine
This is Rietveld 408576698