Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 1312943008: Invalidate background obscuration after loading background images (Closed)

Created:
5 years, 3 months ago by pdr.
Modified:
5 years, 3 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Invalidate background obscuration after loading background images This patch fixes a bug where a background would be considered obscured during loading but would not get reexamined for the background obscuration bit after the image loaded. Other loading codepaths (e.g., <images>) had this case covered but background images were missing this check. BUG=422272 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201804

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
A LayoutTests/paint/invalidation/background-no-longer-obscured-after-loading.html View 1 chunk +14 lines, -0 lines 0 comments Download
A LayoutTests/paint/invalidation/background-no-longer-obscured-after-loading-expected.html View 1 chunk +13 lines, -0 lines 0 comments Download
A LayoutTests/paint/invalidation/resources/bluesquare.png View Binary file 0 comments Download
M Source/core/layout/LayoutBox.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312943008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312943008/1
5 years, 3 months ago (2015-09-04 02:22:46 UTC) #2
pdr.
5 years, 3 months ago (2015-09-04 03:17:24 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-04 03:19:59 UTC) #6
chrishtr
lgtm
5 years, 3 months ago (2015-09-04 17:02:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312943008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312943008/1
5 years, 3 months ago (2015-09-04 17:02:35 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 17:08:27 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201804

Powered by Google App Engine
This is Rietveld 408576698