Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Side by Side Diff: Source/core/layout/LayoutBox.cpp

Issue 1312943008: Invalidate background obscuration after loading background images (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/paint/invalidation/resources/bluesquare.png ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserv ed. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserv ed.
7 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved. 7 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 1335 matching lines...) Expand 10 before | Expand all | Expand 10 after
1346 { 1346 {
1347 if (drawingBackground && (isDocumentElement() || backgroundStolenForBeingBod y())) 1347 if (drawingBackground && (isDocumentElement() || backgroundStolenForBeingBod y()))
1348 return false; 1348 return false;
1349 for (const FillLayer* curLayer = &layers; curLayer; curLayer = curLayer->nex t()) { 1349 for (const FillLayer* curLayer = &layers; curLayer; curLayer = curLayer->nex t()) {
1350 if (curLayer->image() && image == curLayer->image()->data()) { 1350 if (curLayer->image() && image == curLayer->image()->data()) {
1351 bool maybeAnimated = curLayer->image()->cachedImage() && curLayer->i mage()->cachedImage()->image() && curLayer->image()->cachedImage()->image()->may beAnimated(); 1351 bool maybeAnimated = curLayer->image()->cachedImage() && curLayer->i mage()->cachedImage()->image() && curLayer->image()->cachedImage()->image()->may beAnimated();
1352 if (maybeAnimated && drawingBackground) 1352 if (maybeAnimated && drawingBackground)
1353 setShouldDoFullPaintInvalidation(PaintInvalidationDelayedFull); 1353 setShouldDoFullPaintInvalidation(PaintInvalidationDelayedFull);
1354 else 1354 else
1355 setShouldDoFullPaintInvalidation(); 1355 setShouldDoFullPaintInvalidation();
1356
1357 if (drawingBackground)
1358 invalidateBackgroundObscurationStatus();
1356 return true; 1359 return true;
1357 } 1360 }
1358 } 1361 }
1359 return false; 1362 return false;
1360 } 1363 }
1361 1364
1362 bool LayoutBox::intersectsVisibleViewport() 1365 bool LayoutBox::intersectsVisibleViewport()
1363 { 1366 {
1364 LayoutRect rect = visualOverflowRect(); 1367 LayoutRect rect = visualOverflowRect();
1365 LayoutView* layoutView = view(); 1368 LayoutView* layoutView = view();
(...skipping 3370 matching lines...) Expand 10 before | Expand all | Expand 10 after
4736 StyleImage* borderImage = style()->borderImage().image(); 4739 StyleImage* borderImage = style()->borderImage().image();
4737 return borderImage && borderImage->canRender(*this, style()->effectiveZoom() ) && borderImage->isLoaded(); 4740 return borderImage && borderImage->canRender(*this, style()->effectiveZoom() ) && borderImage->isLoaded();
4738 } 4741 }
4739 4742
4740 ShapeOutsideInfo* LayoutBox::shapeOutsideInfo() const 4743 ShapeOutsideInfo* LayoutBox::shapeOutsideInfo() const
4741 { 4744 {
4742 return ShapeOutsideInfo::isEnabledFor(*this) ? ShapeOutsideInfo::info(*this) : nullptr; 4745 return ShapeOutsideInfo::isEnabledFor(*this) ? ShapeOutsideInfo::info(*this) : nullptr;
4743 } 4746 }
4744 4747
4745 } // namespace blink 4748 } // namespace blink
OLDNEW
« no previous file with comments | « LayoutTests/paint/invalidation/resources/bluesquare.png ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698