Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1312903004: Fix emoji font fallback logic on Windows (Closed)

Created:
5 years, 3 months ago by eae
Modified:
5 years, 3 months ago
Reviewers:
wkorman
CC:
blink-reviews, Rik, danakj, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix emoji font fallback logic on Windows Fix handling of emojiFonts in getFontBasedOnUnicodeBlock, the emojiFonts field was incorrectly not marked as static and thus would only be set on the very first invocation of the method. TEST=fast/text/emoji-font-fallback-win.html BUG=516580 R=wkorman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201495

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M LayoutTests/TestExpectations View 1 1 chunk +1 line, -0 lines 0 comments Download
A LayoutTests/fast/text/emoji-font-fallback-win.html View 1 1 chunk +11 lines, -0 lines 0 comments Download
A LayoutTests/fast/text/emoji-font-fallback-win-expected.html View 1 1 chunk +11 lines, -0 lines 0 comments Download
M Source/platform/fonts/win/FontFallbackWin.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
eae
5 years, 3 months ago (2015-08-29 00:23:16 UTC) #2
wkorman
lgtm
5 years, 3 months ago (2015-08-29 00:29:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312903004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312903004/1
5 years, 3 months ago (2015-08-29 00:29:48 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/100519)
5 years, 3 months ago (2015-08-29 03:17:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312903004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312903004/20001
5 years, 3 months ago (2015-08-31 18:35:56 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 19:29:24 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201495

Powered by Google App Engine
This is Rietveld 408576698