Source/platform/fonts/win/FontFallbackWin.cpp - Issue 1312903004: Fix emoji font fallback logic on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/win/FontFallbackWin.cpp

Issue 1312903004: Fix emoji font fallback logic on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/fonts/win/FontFallbackWin.cpp

diff --git a/Source/platform/fonts/win/FontFallbackWin.cpp b/Source/platform/fonts/win/FontFallbackWin.cpp

index 222f64bed7a5b9422b088ce2fe1432eb9eba19e5..a7f5be4cdc1052d3035da781586990baa85dbd20 100644

--- a/Source/platform/fonts/win/FontFallbackWin.cpp

+++ b/Source/platform/fonts/win/FontFallbackWin.cpp

@@ -286,7 +286,7 @@ const UChar* getFontBasedOnUnicodeBlock(int ucs4, SkFontMgr* fontManager)

{

static const UChar* emojiFonts[] = {L"Segoe UI Emoji", L"Segoe UI Symbol"};

static const UChar* symbolFont = L"Segoe UI Symbol";

- const UChar* emojiFont = 0;

+ static const UChar* emojiFont = 0;

static bool initialized = false;

if (!initialized) {

for (size_t i = 0; i < WTF_ARRAY_LENGTH(emojiFonts); i++) {

« no previous file with comments | « LayoutTests/fast/text/emoji-font-fallback-win-expected.html ('k') | no next file » | no next file with comments »