Update NaCl ARM build flags now that gcc used as default compiler.

Update NaCl ARM build flags now that gcc used as default compiler.

The required a native_client change:
  https://codereview.chromium.org/12499011/

Thus this change also brings in NaCl changes from
11084:11126 inclusive.

BUG=196627
TEST=run nacl brower tests one ARM linux

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192249

[Derek Schuff, 2013-03-28 17:40:22]

https://codereview.chromium.org/13129002/diff/1/ppapi/native_client/native_cl...
File ppapi/native_client/native_client.gyp (right):

https://codereview.chromium.org/13129002/diff/1/ppapi/native_client/native_cl...
ppapi/native_client/native_client.gyp:120: # See
http://code.google.com/p/nativeclient/issues/detail?id=2691.
this comment can go away now.

https://codereview.chromium.org/13129002/diff/1/ppapi/native_client/native_cl...
ppapi/native_client/native_client.gyp:128: { # TODO(mcgrathr): This knowledge
really belongs in
If you're going to do this CL atomically with a nacl roll, can this TODO be
resolved as well? And, you probably don't need the extra compile_flag
(especially since it seems there would be no source files left)

[Derek Schuff, 2013-03-28 17:54:33]

https://codereview.chromium.org/13129002/diff/1/ppapi/native_client/native_cl...
File ppapi/native_client/native_client.gyp (right):

https://codereview.chromium.org/13129002/diff/1/ppapi/native_client/native_cl...
ppapi/native_client/native_client.gyp:308:
'../../gpu/gpu_untrusted.gyp:command_buffer_client_untrusted',
If you're going to use -mtp=soft just where it's actually needed, I think youll
also need to add -mtp=soft to these libraries on the chrome side as well as the
ones the IRT uses on the nacl side.

[Sam Clegg, 2013-03-28 23:08:37]

https://codereview.chromium.org/13129002/diff/1/ppapi/native_client/native_cl...
File ppapi/native_client/native_client.gyp (right):

https://codereview.chromium.org/13129002/diff/1/ppapi/native_client/native_cl...
ppapi/native_client/native_client.gyp:120: # See
http://code.google.com/p/nativeclient/issues/detail?id=2691.
On 2013/03/28 17:40:22, Derek Schuff wrote:
> this comment can go away now.

Done.

https://codereview.chromium.org/13129002/diff/1/ppapi/native_client/native_cl...
ppapi/native_client/native_client.gyp:128: { # TODO(mcgrathr): This knowledge
really belongs in
On 2013/03/28 17:40:22, Derek Schuff wrote:
> If you're going to do this CL atomically with a nacl roll, can this TODO be
> resolved as well? And, you probably don't need the extra compile_flag
> (especially since it seems there would be no source files left)

Removed compile_flags.

https://codereview.chromium.org/13129002/diff/1/ppapi/native_client/native_cl...
ppapi/native_client/native_client.gyp:308:
'../../gpu/gpu_untrusted.gyp:command_buffer_client_untrusted',
On 2013/03/28 17:54:33, Derek Schuff wrote:
> If you're going to use -mtp=soft just where it's actually needed, I think
youll
> also need to add -mtp=soft to these libraries on the chrome side as well as
the
> ones the IRT uses on the nacl side.


I went for consistency with X86 which it to use indirect TLS by default.

[Sam Clegg, 2013-03-29 00:43:03]

On 2013/03/28 23:13:32, Sam Clegg wrote:

The try jobs about are for the combined patch of this change plus
https://codereview.chromium.org/12499011/

[Derek Schuff, 2013-03-29 05:43:36]

https://codereview.chromium.org/13129002/diff/8001/ppapi/native_client/native...
File ppapi/native_client/native_client.gyp (right):

https://codereview.chromium.org/13129002/diff/8001/ppapi/native_client/native...
ppapi/native_client/native_client.gyp:127:
'../../native_client/src/untrusted/irt/aeabi_read_tp.S',
This should probably still be moved to irt.gyp per the comment; it could maybe
be another CL but since you're doing a simultaneous DEPS roll+update already,
it's probably better to roll it into this one.

[Sam Clegg, 2013-03-29 18:29:21]

https://codereview.chromium.org/13129002/diff/8001/ppapi/native_client/native...
File ppapi/native_client/native_client.gyp (right):

https://codereview.chromium.org/13129002/diff/8001/ppapi/native_client/native...
ppapi/native_client/native_client.gyp:127:
'../../native_client/src/untrusted/irt/aeabi_read_tp.S',
On 2013/03/29 05:43:36, Derek Schuff wrote:
> This should probably still be moved to irt.gyp per the comment; it could maybe
> be another CL but since you're doing a simultaneous DEPS roll+update already,
> it's probably better to roll it into this one.

Done.

[Derek Schuff, 2013-04-01 17:50:31]

lgtm

[Sam Clegg, 2013-04-02 20:07:25]

+dmichael for ppapi OWNERS

[dmichael (off chromium), 2013-04-02 20:29:12]

lgtm

[commit-bot: I haz the power, 2013-04-03 02:32:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sbc@chromium.org/13129002/55001

[commit-bot: I haz the power, 2013-04-03 02:51:25]

Retried try job too often on win_x64_rel for step(s) compile
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_re...

[commit-bot: I haz the power, 2013-04-03 04:31:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sbc@chromium.org/13129002/55001

[commit-bot: I haz the power, 2013-04-03 04:52:16]

Retried try job too often on win_x64_rel for step(s) compile
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_re...

[commit-bot: I haz the power, 2013-04-03 21:51:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sbc@chromium.org/13129002/87001

[commit-bot: I haz the power, 2013-04-04 08:53:58]

Change committed as 192249

[phoglund_chromium, 2013-04-04 10:54:25]

On 2013/04/04 08:53:58, I haz the power (commit-bot) wrote:
> Change committed as 192249

Reverted this one as it seemed to be the cause of
http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28dais....

[Mark Seaborn, 2013-04-04 14:38:13]

I see a lot of trybot runs on this changeset, but none of them are for the
cros_daisy (ARM) trybot.  Please, if you are specifically changing the ARM
build, test the change on the ARM trybots!  Reviewers, please check for this
too.

On 2013/04/04 10:54:25, phoglund wrote:
> On 2013/04/04 08:53:58, I haz the power (commit-bot) wrote:
> > Change committed as 192249
> 
> Reverted this one as it seemed to be the cause of
>
http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%2520%2528....

The link doesn't work (has it expired already?).  What was the build error?

[Mark Seaborn, 2013-04-04 14:50:21]

On 2013/04/04 14:38:13, Mark Seaborn wrote:
> On 2013/04/04 10:54:25, phoglund wrote:
> > On 2013/04/04 08:53:58, I haz the power (commit-bot) wrote:
> > > Change committed as 192249
> > 
> > Reverted this one as it seemed to be the cause of
> >
>
http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%252520%25....
> 
> The link doesn't work (has it expired already?).  What was the build error?

Working link:
http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28dais...

The build error was:
chromeos-chrome-28.0.1465.0_alpha-r1: make: *** No rule to make target
`native_client/toolchain/.tars/gcc_arm.tgz', needed by
`c/Release/obj/gen/sdk/toolchain/linux_arm_newlib/stamp.untar'.  Stop.

[Mark Seaborn, 2013-04-04 15:14:42]

On 4 April 2013 07:50, <mseaborn@chromium.org> wrote:

> On 2013/04/04 14:38:13, Mark Seaborn wrote:
>
>> On 2013/04/04 10:54:25, phoglund wrote:
>> > On 2013/04/04 08:53:58, I haz the power (commit-bot) wrote:
>> > > Change committed as 192249
>> >
>> > Reverted this one as it seemed to be the cause of
>>
>http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%252520%252528daisy%252529/builds/8501
>> .
>
>
>
>  The link doesn't work (has it expired already?).  What was the build
>> error?
>>
>
> Working link:
>
>
http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28dais...
>

Oh, it appears that Rietveld mangles the link.  The link I receive via
e-mail works, but the link on the Rietveld web page doesn't work.

Mark