Update NaCl ARM build flags now that gcc used as default compiler.

ppapi/native_client/native_client.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'includes': [
     '../../build/common_untrusted.gypi',
   ],
   'conditions': [
     ['disable_nacl==0 and disable_nacl_untrusted==0', {
@@ skipping 96 matching lines @@
               '-lgpu_ipc_untrusted',
               '-lipc_untrusted',
               '-lbase_untrusted',
               '-lshared_memory_support_untrusted',
               '-lsrpc',
               '-limc_syscalls',
               '-lplatform',
               '-lgio',
               '-Wl,--end-group',
               '-lm',
+              '-Wl,--section-start,.rodata=<(NACL_IRT_DATA_START)',
+              '-Wl,-Ttext-segment=<(NACL_IRT_TEXT_START)',
             ],
             # See http://code.google.com/p/nativeclient/issues/detail?id=2691.

[Derek Schuff, 2013/03/28 17:40:22]

this comment can go away now.

[Sam Clegg, 2013/03/28 23:08:37]

Done.

             # The PNaCl linker (gold) does not implement the "-Ttext-segment"
             # option.  However, with the linker for x86, the "-Ttext" option
             # does not affect the executable's base address.
             # TODO(olonho): simplify flags handling and avoid duplication
             # with NaCl logic.
             'conditions': [
-              ['target_arch!="arm"',
-               {
-                 'link_flags': [
-                   '-Wl,--section-start,.rodata=<(NACL_IRT_DATA_START)',
-                   '-Wl,-Ttext-segment=<(NACL_IRT_TEXT_START)',
-                 ]
-               }, { # target_arch == "arm"
-                 # TODO(mcgrathr): This knowledge really belongs in
+              ['target_arch=="arm"',
+               { # TODO(mcgrathr): This knowledge really belongs in

[Derek Schuff, 2013/03/28 17:40:22]

If you're going to do this CL atomically with a nacl roll, can this TODO be
resolved as well? And, you probably don't need the extra compile_flag
(especially since it seems there would be no source files left)

[Sam Clegg, 2013/03/28 23:08:37]

Removed compile_flags.

                  # native_client/src/untrusted/irt/irt.gyp instead of here.
                  # But that builds libirt_browser.a as bitcode, so a native
                  # object does not fit happily there.
                  'sources': [
                    '../../native_client/src/untrusted/irt/aeabi_read_tp.S',
                  ],
-                 'link_flags': [
-                   '-Wl,--section-start,.rodata=<(NACL_IRT_DATA_START)',
-                   '-Wl,-Ttext=<(NACL_IRT_TEXT_START)',
-                   '--pnacl-allow-native',
-                   '-arch', 'arm',
-                   '-Wt,-mtls-use-call',
-                   '-Wl,--pnacl-irt-link',
+                 'compile_flags': [
+                   '-mtp=soft'
                  ],
                },
              ],
              # untrusted.gypi and build_nexe.py currently build
              # both x86-32 and x86-64 whenever target_arch is some
              # flavor of x86.  However, on non-windows platforms
              # we only need one architecture.
              ['OS!="win" and target_arch=="ia32"',
                {
                  'enable_x86_64': 0
@@ skipping 151 matching lines @@
               '<(SHARED_INTERMEDIATE_DIR)/tc_newlib/libarm/libplatform.a',
               '<(SHARED_INTERMEDIATE_DIR)/tc_newlib/libarm/libimc_syscalls.a',
               '<(SHARED_INTERMEDIATE_DIR)/tc_newlib/libarm/libgio.a',
             ],
           },
           'dependencies': [
             '../ppapi_proxy_untrusted.gyp:ppapi_proxy_untrusted',
             '../ppapi_ipc_untrusted.gyp:ppapi_ipc_untrusted',
             '../ppapi_shared_untrusted.gyp:ppapi_shared_untrusted',
             '../../gpu/command_buffer/command_buffer_untrusted.gyp:gles2_utils_untrusted',
             '../../gpu/gpu_untrusted.gyp:command_buffer_client_untrusted',

[Derek Schuff, 2013/03/28 17:54:33]

If you're going to use -mtp=soft just where it's actually needed, I think youll
also need to add -mtp=soft to these libraries on the chrome side as well as the
ones the IRT uses on the nacl side.

[Sam Clegg, 2013/03/28 23:08:37]

I went for consistency with X86 which it to use indirect TLS by default.

             '../../gpu/gpu_untrusted.gyp:command_buffer_common_untrusted',
             '../../gpu/gpu_untrusted.gyp:gles2_implementation_untrusted',
             '../../gpu/gpu_untrusted.gyp:gles2_cmd_helper_untrusted',
             '../../gpu/gpu_untrusted.gyp:gpu_ipc_untrusted',
             '../../components/tracing_untrusted.gyp:tracing_untrusted',
             '../../ipc/ipc_untrusted.gyp:ipc_untrusted',
             '../../base/base_untrusted.gyp:base_untrusted',
             '../../media/media_untrusted.gyp:shared_memory_support_untrusted',
             '../../native_client/src/untrusted/irt/irt.gyp:irt_browser_lib',
             '../../native_client/src/shared/srpc/srpc.gyp:srpc_lib',
             '../../native_client/src/shared/platform/platform.gyp:platform_lib',
             '../../native_client/src/untrusted/nacl/nacl.gyp:imc_syscalls_lib',
             '../../native_client/src/shared/gio/gio.gyp:gio_lib',
           ],
         },
       ],
     }],
   ],
 }