Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 1312763009: Restore old NEON blit_mask_d32_a8 methods. (Closed)

Created:
5 years, 3 months ago by mtklein_C
Modified:
5 years, 3 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Restore old NEON blit_mask_d32_a8 methods. As you'll see from the BUG line, we have a strong indication that the new Sk4px methods regress some devices. This restores the old code back as literally as possible while still fitting in SkOpts framework. This is ideally temporary breathing room. We should get an early indication of if those bugs will improve by watching https://perf.skia.org/#4004 BUG=skia:4117, 525844, 519596, 524149 Committed: https://skia.googlesource.com/skia/+/12d40c18b9f624f3a6b674f10a11504fd3ea5642

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -51 lines) Patch
M src/opts/SkBlitMask_opts.h View 1 chunk +171 lines, -51 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312763009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312763009/1
5 years, 3 months ago (2015-09-01 17:08:22 UTC) #2
mtklein_C
5 years, 3 months ago (2015-09-01 17:13:59 UTC) #5
reed1
lgtm
5 years, 3 months ago (2015-09-01 17:53:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312763009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312763009/1
5 years, 3 months ago (2015-09-01 18:02:43 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 18:03:17 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/12d40c18b9f624f3a6b674f10a11504fd3ea5642

Powered by Google App Engine
This is Rietveld 408576698