[heap] User safer root set accessor when possible.

[heap] User safer root set accessor when possible.

R=mlippautz@chromium.org

Committed: https://crrev.com/bfbcb3d3fbb5bd816fbcedb1f8690d0d09191ec3
Cr-Commit-Position: refs/heads/master@{#30377}

[Michael Lippautz, 2015-08-25 15:13:25]

lgtm

https://codereview.chromium.org/1312763006/diff/1/src/snapshot/serialize.cc
File src/snapshot/serialize.cc (right):

https://codereview.chromium.org/1312763006/diff/1/src/snapshot/serialize.cc#n...
src/snapshot/serialize.cc:956: int id = source_.GetInt();                       
                     \
I would say use const here but since all the other cases also don't specify it
we should probably leave it for uniformity.

[Michael Starzinger, 2015-08-25 15:19:38]

mstarzinger@chromium.org changed reviewers:
+ yangguo@chromium.org

[Michael Starzinger, 2015-08-25 15:19:39]

Mike: Thanks for review!
Yang: PTAL at deserializer.

https://codereview.chromium.org/1312763006/diff/1/src/snapshot/serialize.cc
File src/snapshot/serialize.cc (right):

https://codereview.chromium.org/1312763006/diff/1/src/snapshot/serialize.cc#n...
src/snapshot/serialize.cc:956: int id = source_.GetInt();                       
                     \
On 2015/08/25 15:13:25, Michael Lippautz wrote:
> I would say use const here but since all the other cases also don't specify it
> we should probably leave it for uniformity.

Acknowledged. I'll leave the decision up to Yang, since it's deep inside the
Deserializer.

[Yang, 2015-08-26 10:21:49]

lgtm

https://codereview.chromium.org/1312763006/diff/1/src/snapshot/serialize.cc
File src/snapshot/serialize.cc (right):

https://codereview.chromium.org/1312763006/diff/1/src/snapshot/serialize.cc#n...
src/snapshot/serialize.cc:956: int id = source_.GetInt();                       
                     \
On 2015/08/25 15:19:39, Michael Starzinger wrote:
> On 2015/08/25 15:13:25, Michael Lippautz wrote:
> > I would say use const here but since all the other cases also don't specify
it
> > we should probably leave it for uniformity.
> 
> Acknowledged. I'll leave the decision up to Yang, since it's deep inside the
> Deserializer.

I'm fine with either.

[Michael Starzinger, 2015-08-26 10:23:41]

The CQ bit was checked by mstarzinger@chromium.org

[commit-bot: I haz the power, 2015-08-26 10:23:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1312763006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1312763006/1

[commit-bot: I haz the power, 2015-08-26 10:25:24]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-08-26 10:25:47]

Patchset 1 (id:??) landed as
https://crrev.com/bfbcb3d3fbb5bd816fbcedb1f8690d0d09191ec3
Cr-Commit-Position: refs/heads/master@{#30377}