Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 1312733004: Revert of chrome-si/initializers expectations for protobufs (Closed)

Created:
5 years, 3 months ago by Nico
Modified:
5 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of chrome-si/initializers expectations for protobufs (patchset #1 id:1 of https://codereview.chromium.org/1312423002/ ) Reason for revert: We do not tolerate static initializer regressions. Original issue's description: > chrome-si/initializers expectations for protobufs > > Temporarily expand chrome-si/initializers expectations due to new static > initializers from ProtoBuf. > > BUG=525054, 81439 > TBR=pkasting@chromium.org,mustaq@chromium.org > > Committed: https://crrev.com/aa9c64979b341fa34c5668b746014b78015d22fe > Cr-Commit-Position: refs/heads/master@{#345596} TBR=mustaq@chromium.org,pkasting@chromium.org,rogerta@chromium.org,battre@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=525054, 81439 Committed: https://crrev.com/6e42b0a09c83fff8c4e0f3a2abcc51e4d4d62426 Cr-Commit-Position: refs/heads/master@{#345788}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools/perf_expectations/perf_expectations.json View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
Created Revert of chrome-si/initializers expectations for protobufs
5 years, 3 months ago (2015-08-27 04:06:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312733004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312733004/1
5 years, 3 months ago (2015-08-27 04:07:01 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-27 04:08:21 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6e42b0a09c83fff8c4e0f3a2abcc51e4d4d62426 Cr-Commit-Position: refs/heads/master@{#345788}
5 years, 3 months ago (2015-08-27 04:09:05 UTC) #4
mustaq
5 years, 3 months ago (2015-08-27 14:43:12 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698