Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 1312423002: chrome-si/initializers expectations for protobufs (Closed)

Created:
5 years, 3 months ago by battre
Modified:
5 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chrome-si/initializers expectations for protobufs Temporarily expand chrome-si/initializers expectations due to new static initializers from ProtoBuf. BUG=525054, 81439 TBR=pkasting@chromium.org,mustaq@chromium.org Committed: https://crrev.com/aa9c64979b341fa34c5668b746014b78015d22fe Cr-Commit-Position: refs/heads/master@{#345596}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools/perf_expectations/perf_expectations.json View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Roger Tawa OOO till Jul 10th
lgtm
5 years, 3 months ago (2015-08-26 13:14:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312423002/1
5 years, 3 months ago (2015-08-26 13:15:25 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-26 13:24:52 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/aa9c64979b341fa34c5668b746014b78015d22fe Cr-Commit-Position: refs/heads/master@{#345596}
5 years, 3 months ago (2015-08-26 13:25:46 UTC) #6
Nico
Not lgtm. Static initializers don't get temporarily raised. The offending CL gets reverted instead.
5 years, 3 months ago (2015-08-27 03:52:19 UTC) #8
Nico
5 years, 3 months ago (2015-08-27 04:06:48 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1312733004/ by thakis@chromium.org.

The reason for reverting is: We do not tolerate static initializer regressions..

Powered by Google App Engine
This is Rietveld 408576698