Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1312723002: Service workers: Add test for HTTP to HTTPS redirect (Closed)

Created:
5 years, 4 months ago by falken
Modified:
5 years, 4 months ago
Reviewers:
Kunihiko Sakamoto, horo
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Service workers: Add test for HTTP to HTTPS redirect Test for Chromium change: https://codereview.chromium.org/1315483002 BUG=522900 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201054

Patch Set 1 #

Total comments: 2

Patch Set 2 : rm unused #

Patch Set 3 : add a negative case #

Total comments: 2

Patch Set 4 : wait for unregister #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -0 lines) Patch
A LayoutTests/http/tests/serviceworker/http-to-https-redirect-and-register.html View 1 2 1 chunk +48 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/serviceworker/resources/register.html View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
falken
ptal
5 years, 4 months ago (2015-08-24 05:43:25 UTC) #2
Kunihiko Sakamoto
lgtm https://codereview.chromium.org/1312723002/diff/1/LayoutTests/http/tests/serviceworker/http-to-https-redirect-and-register.html File LayoutTests/http/tests/serviceworker/http-to-https-redirect-and-register.html (right): https://codereview.chromium.org/1312723002/diff/1/LayoutTests/http/tests/serviceworker/http-to-https-redirect-and-register.html#newcode14 LayoutTests/http/tests/serviceworker/http-to-https-redirect-and-register.html:14: var script = 'resources/empty-worker.js'; nit: Unused variable.
5 years, 4 months ago (2015-08-24 05:57:39 UTC) #3
falken
thanks https://codereview.chromium.org/1312723002/diff/1/LayoutTests/http/tests/serviceworker/http-to-https-redirect-and-register.html File LayoutTests/http/tests/serviceworker/http-to-https-redirect-and-register.html (right): https://codereview.chromium.org/1312723002/diff/1/LayoutTests/http/tests/serviceworker/http-to-https-redirect-and-register.html#newcode14 LayoutTests/http/tests/serviceworker/http-to-https-redirect-and-register.html:14: var script = 'resources/empty-worker.js'; On 2015/08/24 05:57:39, Kunihiko ...
5 years, 4 months ago (2015-08-24 06:09:02 UTC) #4
falken
ksakamoto: I added a new test for the negative case, to ensure the change isn't ...
5 years, 4 months ago (2015-08-24 07:08:55 UTC) #5
Kunihiko Sakamoto
https://codereview.chromium.org/1312723002/diff/40001/LayoutTests/http/tests/serviceworker/resources/register.html File LayoutTests/http/tests/serviceworker/resources/register.html (right): https://codereview.chromium.org/1312723002/diff/40001/LayoutTests/http/tests/serviceworker/resources/register.html#newcode9 LayoutTests/http/tests/serviceworker/resources/register.html:9: registration.unregister(); You might want to wait for completion as ...
5 years, 4 months ago (2015-08-24 07:31:58 UTC) #6
falken
https://codereview.chromium.org/1312723002/diff/40001/LayoutTests/http/tests/serviceworker/resources/register.html File LayoutTests/http/tests/serviceworker/resources/register.html (right): https://codereview.chromium.org/1312723002/diff/40001/LayoutTests/http/tests/serviceworker/resources/register.html#newcode9 LayoutTests/http/tests/serviceworker/resources/register.html:9: registration.unregister(); On 2015/08/24 07:31:58, Kunihiko Sakamoto wrote: > You ...
5 years, 4 months ago (2015-08-24 07:41:07 UTC) #7
Kunihiko Sakamoto
LGTM On 2015/08/24 07:41:07, falken wrote: > It's actually not necessary currently since the two ...
5 years, 4 months ago (2015-08-24 07:45:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312723002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312723002/60001
5 years, 4 months ago (2015-08-24 08:19:47 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/102981)
5 years, 4 months ago (2015-08-24 08:50:52 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312723002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312723002/60001
5 years, 4 months ago (2015-08-24 09:04:58 UTC) #14
commit-bot: I haz the power
5 years, 4 months ago (2015-08-24 09:40:50 UTC) #15
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201054

Powered by Google App Engine
This is Rietveld 408576698