Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1315483002: Service workers: Allow HTTPS pages arrived at via HTTP redirect to use SW (Closed)

Created:
5 years, 4 months ago by falken
Modified:
5 years, 4 months ago
Reviewers:
Kunihiko Sakamoto, horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+serviceworker, kinuko+watch, blink-worker-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Service workers: Allow HTTPS pages arrived at via HTTP redirect to use SW This should be allowed. It regressed in https://crrev.com/1db36fd BUG=522900 TEST=https://codereview.chromium.org/1312723002 Committed: https://crrev.com/f72c80b5cbc8c6621f7703036d989b40bd6b31ab Cr-Commit-Position: refs/heads/master@{#345033}

Patch Set 1 #

Patch Set 2 : fmt #

Patch Set 3 : fix unittest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -7 lines) Patch
M content/browser/service_worker/service_worker_request_handler.cc View 1 1 chunk +5 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_request_handler_unittest.cc View 1 2 2 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
falken
ptal
5 years, 4 months ago (2015-08-24 05:43:49 UTC) #2
Kunihiko Sakamoto
lgtm
5 years, 4 months ago (2015-08-24 05:56:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315483002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315483002/20001
5 years, 4 months ago (2015-08-24 06:05:36 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/45635)
5 years, 4 months ago (2015-08-24 06:29:41 UTC) #7
falken
ksakamoto: sorry, can you take another look? I had to change unittests.
5 years, 4 months ago (2015-08-24 07:07:47 UTC) #8
Kunihiko Sakamoto
Still LGTM
5 years, 4 months ago (2015-08-24 07:26:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315483002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315483002/40001
5 years, 4 months ago (2015-08-24 07:41:44 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-08-24 08:18:57 UTC) #12
commit-bot: I haz the power
5 years, 4 months ago (2015-08-24 08:19:38 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f72c80b5cbc8c6621f7703036d989b40bd6b31ab
Cr-Commit-Position: refs/heads/master@{#345033}

Powered by Google App Engine
This is Rietveld 408576698