Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2921)

Unified Diff: extensions/browser/guest_view/web_view/web_view_renderer_state.h

Issue 1312653003: Fix for WebView accessible resources. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments by kalman@. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/web_view/web_view_renderer_state.h
diff --git a/extensions/browser/guest_view/web_view/web_view_renderer_state.h b/extensions/browser/guest_view/web_view/web_view_renderer_state.h
index c43afd2ea7b1072db5e9220d793bb61445a8fac2..5af7009463fcc5c39383e06141b740ba9a7814ab 100644
--- a/extensions/browser/guest_view/web_view/web_view_renderer_state.h
+++ b/extensions/browser/guest_view/web_view/web_view_renderer_state.h
@@ -24,8 +24,6 @@ namespace extensions {
class WebViewGuest;
-// This class keeps track of <webview> renderer state for use on the IO thread.
-// All methods should be called on the IO thread.
not at google - send to devlin 2015/09/03 20:17:54 You might actually want to keep a comment, just ha
paulmeyer 2015/09/08 18:51:36 I removed this comment because the same info is al
class WebViewRendererState {
public:
struct WebViewInfo {
@@ -43,19 +41,19 @@ class WebViewRendererState {
static WebViewRendererState* GetInstance();
// Looks up the information for the embedder <webview> for a given render
not at google - send to devlin 2015/09/03 20:17:54 I don't like the way these comments (for all funct
paulmeyer 2015/09/08 18:51:36 Updated the comments.
- // view, if one exists. Called on the IO thread.
+ // view, if one exists.
bool GetInfo(int guest_process_id,
int guest_routing_id,
WebViewInfo* web_view_info) const;
// Looks up the information for the owner for a given guest process in a
- // <webview>. Called on the IO thread.
+ // <webview>.
bool GetOwnerInfo(int guest_process_id,
int* owner_process_id,
std::string* owner_host) const;
// Looks up the partition info for the embedder <webview> for a given guest
- // process. Called on the IO thread.
+ // process.
bool GetPartitionID(int guest_process_id, std::string* partition_id) const;
// Returns true if the given renderer is used by webviews.

Powered by Google App Engine
This is Rietveld 408576698