Fix for WebView accessible resources.

extensions/browser/guest_view/web_view/web_view_renderer_state.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // WebViewRendererState manages state data for WebView guest renderer processes.
 //
 // This class's data can be accessed via its methods from both the UI and IO
 // threads, and uses locks to mediate this access. When making changes to this
 // class, ensure that you avoid introducing any reentrant code in the methods,
 // and that you always aquire the locks in the order |web_view_info_map_lock_|
 // -> |web_view_partition_id_map_lock_| (if both are needed in one method).
 
 #ifndef EXTENSIONS_BROWSER_GUEST_VIEW_WEB_VIEW_WEB_VIEW_RENDERER_STATE_H_
 #define EXTENSIONS_BROWSER_GUEST_VIEW_WEB_VIEW_WEB_VIEW_RENDERER_STATE_H_
 
 #include <map>
 #include <set>
 #include <string>
 #include <utility>
 
 #include "base/memory/singleton.h"
 
 namespace extensions {
 
 class WebViewGuest;
 
-// This class keeps track of <webview> renderer state for use on the IO thread.
-// All methods should be called on the IO thread.

[not at google - send to devlin, 2015/09/03 20:17:54]

You might actually want to keep a comment, just have it "Keeps track of
<webview> renderer state. Can be used on any thread."

[paulmeyer, 2015/09/08 18:51:36]

I removed this comment because the same info is already at the top of the file.

 class WebViewRendererState {
  public:
   struct WebViewInfo {
     int embedder_process_id;
     int instance_id;
     int rules_registry_id;
     std::string partition_id;
     std::string owner_host;
     std::set<int> content_script_ids;
 
     WebViewInfo();
     ~WebViewInfo();
   };
 
   static WebViewRendererState* GetInstance();
 
   // Looks up the information for the embedder <webview> for a given render

[not at google - send to devlin, 2015/09/03 20:17:54]

I don't like the way these comments (for all functions) match the
implementations. It should be along the lines of:

"Looks up the information for the embedder <webview> for a RenderViewHost given
its process and view ID. Returns true and writes the information to
|web_view_info| if found, otherwise returns false."

it's a mystery why this doesn't just return a scoped_ptr<WebViewInfo> but
whatever.

it should also take a RenderFrameHost* rather than this ID pair, but one step at
a time.

[paulmeyer, 2015/09/08 18:51:36]

Updated the comments.

-  // view, if one exists. Called on the IO thread.
+  // view, if one exists.
   bool GetInfo(int guest_process_id,
                int guest_routing_id,
                WebViewInfo* web_view_info) const;
 
   // Looks up the information for the owner for a given guest process in a
-  // <webview>. Called on the IO thread.
+  // <webview>.
   bool GetOwnerInfo(int guest_process_id,
                     int* owner_process_id,
                     std::string* owner_host) const;
 
   // Looks up the partition info for the embedder <webview> for a given guest
-  // process. Called on the IO thread.
+  // process.
   bool GetPartitionID(int guest_process_id, std::string* partition_id) const;
 
   // Returns true if the given renderer is used by webviews.
   bool IsGuest(int render_process_id) const;
 
   void AddContentScriptIDs(int embedder_process_id,
                            int view_instance_id,
                            const std::set<int>& script_ids);
   void RemoveContentScriptIDs(int embedder_process_id,
                               int view_instance_id,
@@ skipping 31 matching lines @@
   mutable base::Lock web_view_info_map_lock_;
   WebViewPartitionIDMap web_view_partition_id_map_;
   mutable base::Lock web_view_partition_id_map_lock_;
 
   DISALLOW_COPY_AND_ASSIGN(WebViewRendererState);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_BROWSER_GUEST_VIEW_WEB_VIEW_WEB_VIEW_RENDERER_STATE_H_