Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1069)

Issue 1312593003: Fix bugs in gcloud storage e2e test (Closed)

Created:
5 years, 3 months ago by Søren Gjesse
Modified:
5 years, 3 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org, Bill Hesse
Base URL:
git@github.com:dart-lang/gcloud.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix bugs in gcloud storage e2e test The ACLs returned include a 'user-ID' entry in adition to the ones set when creating the object. The scope for misc@dartlang.org must be a group otherwise the error "status: 400, message: Invalid argument" is returned. Removed the solo_, as it looks like running the test no longer hits a rate limit. BUG= https://github.com/dart-lang/gcloud/issues/32 R=kustermann@google.com Committed: https://github.com/dart-lang/gcloud/commit/d9b9222f91e4d9a92d8ae6ffcf0c4533d91bde28

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M test/storage/e2e_test.dart View 3 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Gjesse
5 years, 3 months ago (2015-09-03 13:53:22 UTC) #1
kustermann
LGTM
5 years, 3 months ago (2015-09-03 14:22:50 UTC) #2
Søren Gjesse
5 years, 3 months ago (2015-09-03 14:23:29 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d9b9222f91e4d9a92d8ae6ffcf0c4533d91bde28 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698