Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: test/storage/e2e_test.dart

Issue 1312593003: Fix bugs in gcloud storage e2e test (Closed) Base URL: git@github.com:dart-lang/gcloud.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/storage/e2e_test.dart
diff --git a/test/storage/e2e_test.dart b/test/storage/e2e_test.dart
index c27efad10226c315451215e9d2f20902fef3ccd9..77a4f838ba474375e6128a5100688a45d7319c2a 100644
--- a/test/storage/e2e_test.dart
+++ b/test/storage/e2e_test.dart
@@ -80,8 +80,7 @@ runTests(Storage storage, Bucket testBucket) {
});
});
- // TODO: Remove solo_ here when the rate-limit issue have been resolved.
- solo_group('object', () {
+ group('object', () {
// Run all object tests in the same bucket to try to avoid the rate-limit
// for creating and deleting buckets while testing.
Future withTestBucket(function) {
@@ -171,7 +170,7 @@ runTests(Storage storage, Bucket testBucket) {
[new AclEntry(AclScope.allUsers, AclPermission.WRITE),
new AclEntry(new AccountScope('sgjesse@google.com'),
AclPermission.WRITE),
- new AclEntry(new AccountScope('misc@dartlang.org'),
+ new AclEntry(new GroupScope('misc@dartlang.org'),
AclPermission.READ)]);
Acl acl4 = new Acl(
[new AclEntry(AclScope.allUsers, AclPermission.WRITE),
@@ -182,11 +181,14 @@ runTests(Storage storage, Bucket testBucket) {
new AclEntry(new DomainScope('dartlang.org'),
AclPermission.FULL_CONTROL)]);
+ // The expected length of the returned ACL is one longer than the one
+ // use during creation as an additional 'used-ID' ACL entry is added
+ // by cloud storage during creation.
return Future.forEach([
- () => test('test-1', acl1, 1),
- () => test('test-2', acl2, 2),
- () => test('test-3', acl3, 3),
- () => test('test-4', acl4, 4)
+ () => test('test-1', acl1, acl1.entries.length + 1),
+ () => test('test-2', acl2, acl2.entries.length + 1),
+ () => test('test-3', acl3, acl3.entries.length + 1),
+ () => test('test-4', acl4, acl4.entries.length + 1)
], (f) => f().then(expectAsync((_) {})));
});
});
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698