Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: src/extensions/externalize-string-extension.cc

Issue 1312553003: [heap] Prevent direct access to ExternalStringTable. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_cleanup-heap-root-set-1
Patch Set: Addressed comments. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/api.cc ('k') | src/heap/heap.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/extensions/externalize-string-extension.cc
diff --git a/src/extensions/externalize-string-extension.cc b/src/extensions/externalize-string-extension.cc
index 3eaa70e515ee1f2b5c16f6833ef5f775ee347a25..9241e9f4de87e76abd86d739a18481528b61a569 100644
--- a/src/extensions/externalize-string-extension.cc
+++ b/src/extensions/externalize-string-extension.cc
@@ -98,7 +98,7 @@ void ExternalizeStringExtension::Externalize(
result = string->MakeExternal(resource);
if (result) {
i::Isolate* isolate = reinterpret_cast<i::Isolate*>(args.GetIsolate());
- isolate->heap()->external_string_table()->AddString(*string);
+ isolate->heap()->RegisterExternalString(*string);
}
if (!result) delete resource;
} else {
@@ -109,7 +109,7 @@ void ExternalizeStringExtension::Externalize(
result = string->MakeExternal(resource);
if (result) {
i::Isolate* isolate = reinterpret_cast<i::Isolate*>(args.GetIsolate());
- isolate->heap()->external_string_table()->AddString(*string);
+ isolate->heap()->RegisterExternalString(*string);
}
if (!result) delete resource;
}
« no previous file with comments | « src/api.cc ('k') | src/heap/heap.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698