Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Unified Diff: Source/core/css/CSSPrimitiveValue.cpp

Issue 1312543003: Split out Attribute from CSSPrimitiveValue (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@clean_up_get_string_value
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/CSSPrimitiveValue.h ('k') | Source/core/css/RuleFeature.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/CSSPrimitiveValue.cpp
diff --git a/Source/core/css/CSSPrimitiveValue.cpp b/Source/core/css/CSSPrimitiveValue.cpp
index bcf12717c54e0bf41b70c9834aa301f6232a2009..2a6bdb93b1b00d9d5c05b6d530caf8313bb2217e 100644
--- a/Source/core/css/CSSPrimitiveValue.cpp
+++ b/Source/core/css/CSSPrimitiveValue.cpp
@@ -351,7 +351,6 @@ void CSSPrimitiveValue::cleanup()
case UnitType::CustomIdentifier:
case UnitType::String:
case UnitType::URI:
- case UnitType::Attribute:
if (m_value.string)
m_value.string->deref();
break;
@@ -745,7 +744,6 @@ String CSSPrimitiveValue::getStringValue() const
switch (type()) {
case UnitType::CustomIdentifier:
case UnitType::String:
- case UnitType::Attribute:
case UnitType::URI:
return m_value.string;
default:
@@ -846,7 +844,6 @@ const char* CSSPrimitiveValue::unitTypeToString(UnitType type)
case UnitType::URI:
case UnitType::ValueID:
case UnitType::PropertyID:
- case UnitType::Attribute:
case UnitType::RGBColor:
case UnitType::Calc:
case UnitType::Shape:
@@ -920,16 +917,6 @@ String CSSPrimitiveValue::customCSSText() const
case UnitType::PropertyID:
text = propertyName(m_value.propertyID);
break;
- case UnitType::Attribute: {
- StringBuilder result;
- result.reserveCapacity(6 + m_value.string->length());
- result.appendLiteral("attr(");
- result.append(m_value.string);
- result.append(')');
-
- text = result.toString();
- break;
- }
case UnitType::RGBColor: {
text = Color(m_value.rgbcolor).serializedAsCSSComponentValue();
break;
@@ -996,7 +983,6 @@ bool CSSPrimitiveValue::equals(const CSSPrimitiveValue& other) const
case UnitType::CustomIdentifier:
case UnitType::String:
case UnitType::URI:
- case UnitType::Attribute:
return equal(m_value.string, other.m_value.string);
case UnitType::RGBColor:
return m_value.rgbcolor == other.m_value.rgbcolor;
« no previous file with comments | « Source/core/css/CSSPrimitiveValue.h ('k') | Source/core/css/RuleFeature.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698