Issue 1312493006: Change fixup_pdf_template.py to open files in binary mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1312493006: Change fixup_pdf_template.py to open files in binary mode. (Closed)

Created:
5 years, 3 months ago by Lei Zhang

Modified:
5 years, 3 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium@master

Target Ref:
refs/heads/master

Visibility:
Public.

Change fixup_pdf_template.py to open files in binary mode. Fix for the pixel test failure on Windows from commit 870b5b6793fa. Seems to work for me on Windows. TBR=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/7c9e4529f63cc2ba47dd9585058c8ee8e546bc1a

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	testing/tools/fixup_pdf_template.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

Lei Zhang

Committed patchset #1 (id:1) manually as 7c9e4529f63cc2ba47dd9585058c8ee8e546bc1a (tree was closed).

5 years, 3 months ago (2015-09-02 23:31:46 UTC) #2

Message was sent while issue was closed.

lgtm