testing/tools/fixup_pdf_template.py - Issue 1312493006: Change fixup_pdf_template.py to open files in binary mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: testing/tools/fixup_pdf_template.py

Issue 1312493006: Change fixup_pdf_template.py to open files in binary mode. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: testing/tools/fixup_pdf_template.py

diff --git a/testing/tools/fixup_pdf_template.py b/testing/tools/fixup_pdf_template.py

index a43db55ee9f51b9f8ab1889c46e1de88ac7e6d06..80a712f6e89d6903d372a36935f70057b09c538e 100755

--- a/testing/tools/fixup_pdf_template.py

+++ b/testing/tools/fixup_pdf_template.py

@@ -74,8 +74,8 @@ class TemplateProcessor:

def expand_file(input_path, output_path):

processor = TemplateProcessor()

try:

- with open(input_path, 'r') as infile:

- with open(output_path, 'w') as outfile:

+ with open(input_path, 'rb') as infile:

+ with open(output_path, 'wb') as outfile:

for line in infile:

outfile.write(processor.process_line(line))

except IOError:

« no previous file with comments | « no previous file | no next file » | no next file with comments »