Compile remoting client plugin with GN

net/net.gypi

Index: net/net.gypi
diff --git a/net/net.gypi b/net/net.gypi
index 28921c6fb92c46bdc0179fb7cb543fe0a0c8e02c..842a7852340a42e29b112a7bfc82c5f7bf7001f7 100644
--- a/net/net.gypi
+++ b/net/net.gypi
@@ -156,8 +156,6 @@
       'socket/ssl_client_socket.h',
       'socket/ssl_client_socket_openssl.cc',
       'socket/ssl_client_socket_openssl.h',
-      'socket/ssl_client_socket_pool.cc',
-      'socket/ssl_client_socket_pool.h',

[davidben, 2015/08/28 17:08:27]

Why were these changes needed? (I certainly believe that you don't need these
files. Just not what it has to do with GN. Does some stricter checking somewhere
cause problems?)

[Sergey Ulanov, 2015/08/31 21:59:33]

The files I moved here should not be part of net_nacl_common_sources because
they have dependencies on files that are not on this list. With GYP the lib was
compiled to .a archive, and these unmet dependency were ignored when linking.
With GN src/net is linked as bunch of .o files without .a, so now it tries to
resolve all symbols in this files and fails to link them. 

[davidben, 2015/08/31 23:11:06]

Gotcha. Thanks for clarifying.

       'socket/ssl_socket.h',
       'ssl/channel_id_service.cc',
       'ssl/channel_id_service.h',
@@ -288,8 +286,6 @@
       'quic/crypto/strike_register_client.h',
       'quic/iovector.cc',
       'quic/iovector.h',
-      'quic/network_connection.cc',
-      'quic/network_connection.h',
       'quic/p2p/quic_p2p_crypto_config.cc',
       'quic/p2p/quic_p2p_crypto_config.h',
       'quic/p2p/quic_p2p_crypto_stream.cc',
@@ -332,8 +328,6 @@
       'quic/quic_crypto_stream.h',
       'quic/quic_data_reader.cc',
       'quic/quic_data_reader.h',
-      'quic/quic_data_stream.cc',
-      'quic/quic_data_stream.h',
       'quic/quic_data_writer.cc',
       'quic/quic_data_writer.h',
       'quic/quic_default_packet_writer.cc',
@@ -357,8 +351,6 @@
       'quic/quic_protocol.h',
       'quic/quic_received_packet_manager.cc',
       'quic/quic_received_packet_manager.h',
-      'quic/quic_reliable_client_stream.cc',
-      'quic/quic_reliable_client_stream.h',

[davidben, 2015/08/28 17:08:27]

Someone from QUIC should probably review this. I'm not clear on how subsetting
QUIC works. I'm guessing you want quic/p2p but don't care about anything
implementing SPDY things?

+rch

[Sergey Ulanov, 2015/08/31 21:59:33]

That's right. We need to avoid all SPDY dependencies because they pull bunch of
other stuff that we don't need, e.g. zlib.

[Ryan Hamilton, 2015/09/02 19:22:58]

Makes sense to me.

       'quic/quic_sent_entropy_manager.cc',
       'quic/quic_sent_entropy_manager.h',
       'quic/quic_sent_packet_manager.cc',
@@ -369,8 +361,6 @@
       'quic/quic_session.h',
       'quic/quic_socket_address_coder.cc',
       'quic/quic_socket_address_coder.h',
-      'quic/quic_spdy_session.cc',
-      'quic/quic_spdy_session.h',
       'quic/quic_stream_sequencer.cc',
       'quic/quic_stream_sequencer.h',
       'quic/quic_sustained_bandwidth_recorder.cc',
@@ -1009,16 +999,24 @@
       'quic/crypto/chacha20_poly1305_encrypter_nss.cc',
       'quic/crypto/channel_id_nss.cc',
       'quic/crypto/p256_key_exchange_nss.cc',
+      'quic/network_connection.cc',
+      'quic/network_connection.h',
       'quic/quic_chromium_client_session.cc',
       'quic/quic_chromium_client_session.h',
       'quic/quic_client_session_base.cc',
       'quic/quic_client_session_base.h',
+      'quic/quic_data_stream.cc',
+      'quic/quic_data_stream.h',
       'quic/quic_headers_stream.cc',
       'quic/quic_headers_stream.h',
       'quic/quic_http_stream.cc',
       'quic/quic_http_stream.h',
       'quic/quic_http_utils.cc',
       'quic/quic_http_utils.h',
+      'quic/quic_reliable_client_stream.cc',
+      'quic/quic_reliable_client_stream.h',
+      'quic/quic_spdy_session.cc',
+      'quic/quic_spdy_session.h',
       'quic/quic_stream_factory.cc',
       'quic/quic_stream_factory.h',
       'quic/spdy_utils.cc',
@@ -1053,6 +1051,8 @@
       'socket/socks_client_socket_pool.h',
       'socket/ssl_client_socket_nss.cc',
       'socket/ssl_client_socket_nss.h',
+      'socket/ssl_client_socket_pool.cc',
+      'socket/ssl_client_socket_pool.h',
       'socket/ssl_server_socket.h',
       'socket/ssl_server_socket_nss.cc',
       'socket/ssl_server_socket_nss.h',